Hadoop Common
  1. Hadoop Common
  2. HADOOP-5533

Recovery duration shown on the jobtracker webpage is inaccurate

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.20.1
    • Component/s: None
    • Labels:
      None

      Description

      Recovery manager starts the timer once all the job history filenames are recovered. Ideally the time to recover the filename should also be considered as part of the recovery duration.

      1. HADOOP-5533-v1.0.patch
        1 kB
        Amar Kamat
      2. HADOOP-5533-v1.2.patch
        3 kB
        Amar Kamat
      3. HADOOP-5533-v1.3.patch
        2 kB
        Amar Kamat
      4. HADOOP-5533-v1.4.patch
        3 kB
        Amar Kamat

        Activity

        Hide
        Amar Kamat added a comment -

        Attaching a straight forward fix. Result of test-patch

        [exec] -1 overall.  
             [exec] 
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec] 
             [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
             [exec]                         Please justify why no tests are needed for this patch.
             [exec] 
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec] 
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec] 
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
             [exec] 
             [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
             [exec] 
             [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
        
        Show
        Amar Kamat added a comment - Attaching a straight forward fix. Result of test-patch [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        Hide
        Vinod Kumar Vavilapalli added a comment -

        I think it will be useful to also show the start and end times of recovery.

        Show
        Vinod Kumar Vavilapalli added a comment - I think it will be useful to also show the start and end times of recovery.
        Hide
        Amar Kamat added a comment -

        Attaching a patch that provides more information about the recovery duration. Result of test-patch

         [exec] -1 overall.  
             [exec] 
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec] 
             [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
             [exec]                         Please justify why no tests are needed for this patch.
             [exec] 
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec] 
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec] 
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
             [exec] 
             [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
             [exec] 
             [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
        
        Show
        Amar Kamat added a comment - Attaching a patch that provides more information about the recovery duration. Result of test-patch [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        Hide
        Amar Kamat added a comment -

        Attaching a patch that prints the total time spent in filename recovery and job recovery (read + parsing + replay). Result of test-patch

        [exec] -1 overall.  
             [exec] 
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec] 
             [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
             [exec]                         Please justify why no tests are needed for this patch.
             [exec] 
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec] 
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec] 
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
             [exec] 
             [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
             [exec] 
             [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
        
        Show
        Amar Kamat added a comment - Attaching a patch that prints the total time spent in filename recovery and job recovery (read + parsing + replay). Result of test-patch [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        Hide
        Amareshwari Sriramadasu added a comment -

        One Minor nit :
        In the code change,

        @@ -1313,7 +1320,14 @@
                 }
               }
         
        -      recoveryDuration = System.currentTimeMillis() - recoveryStartTime;
        +      LOG.info("Took a total of " 
        +               + StringUtils.formatTime(System.currentTimeMillis() 
        +                                        - recoveryStartTime) 
        +               + " for parsing and recovering all the jobs from history.");
        +
        +      recoveryDuration = System.currentTimeMillis() - recoveryProcessStartTime;
        

        Two calls to System.currentTimeMillis() can be combined into one.

        Show
        Amareshwari Sriramadasu added a comment - One Minor nit : In the code change, @@ -1313,7 +1320,14 @@ } } - recoveryDuration = System.currentTimeMillis() - recoveryStartTime; + LOG.info("Took a total of " + + StringUtils.formatTime(System.currentTimeMillis() + - recoveryStartTime) + + " for parsing and recovering all the jobs from history."); + + recoveryDuration = System.currentTimeMillis() - recoveryProcessStartTime; Two calls to System.currentTimeMillis() can be combined into one.
        Hide
        Amar Kamat added a comment -

        Attaching a patch incorporating Amareshwari's super minor comment.

        Show
        Amar Kamat added a comment - Attaching a patch incorporating Amareshwari's super minor comment.
        Hide
        Amareshwari Sriramadasu added a comment -

        +1

        Show
        Amareshwari Sriramadasu added a comment - +1
        Hide
        Sharad Agarwal added a comment -

        I just committed this. Thanks Amar!

        Show
        Sharad Agarwal added a comment - I just committed this. Thanks Amar!
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #811 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/811/ )

          People

          • Assignee:
            Amar Kamat
            Reporter:
            Amar Kamat
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development