[HADOOP-5449] Verify if JobHistory.HistoryCleaner works as expected

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 0.19.2
• Hadoop Flags: Reviewed
• Assignee: Amareshwari Sriramadasu
• Reporter: Amar Kamat
• Created: 10/Mar/09 07:38
• Updated: 03/Aug/09 12:59
• Resolved: 13/Mar/09 05:08

Description

Here is the piece of code I doubt

public void run(){
      if (isRunning){
        return;
      }
      now = System.currentTimeMillis();
      // clean history only once a day at max
      if (lastRan ==0 || (now - lastRan) < ONE_DAY_IN_MS){
        return;
      }
      lastRan = now;
.....
// main code for cleaning
}

lastRun is initialized to 0 and hence HistoryCleaner will never execute the main code. Also a testcase should be written for JobHistory.HistoryCleaner to check if it works as expected.