Hadoop Common
  1. Hadoop Common
  2. HADOOP-5423

It should be posible to specify metadata for the output file produced by SequenceFile.Sorter.sort

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.19.1
    • Fix Version/s: 0.21.0
    • Component/s: io
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Activity

      Hide
      Michael Tamm added a comment -

      I attached a patch, which fixes this issue.

      Show
      Michael Tamm added a comment - I attached a patch, which fixes this issue.
      Hide
      Doug Cutting added a comment -

      Can you please add a test for this, probably to TestSequenceFile.java? Thanks!

      Show
      Doug Cutting added a comment - Can you please add a test for this, probably to TestSequenceFile.java? Thanks!
      Hide
      Michael Tamm added a comment -

      I just attached TestSequenceFile.patch, which adds the test for metadata handling by SequenceFile.Sorter to the already existing testSequenceFileMetadata method. (This patch of course uses the new SequenceFile.Sorter constructor provided by SequenceFile.patch.)

      Show
      Michael Tamm added a comment - I just attached TestSequenceFile.patch, which adds the test for metadata handling by SequenceFile.Sorter to the already existing testSequenceFileMetadata method. (This patch of course uses the new SequenceFile.Sorter constructor provided by SequenceFile.patch .)
      Hide
      Doug Cutting added a comment -

      The test looks good. Can you please combine the two patches into a single patch file, then select "Submit Patch" to trigger automated testing? Thanks!

      Also, the "Assignee" should stay set to the primary author of the patch, so that they retain credit for the contribution.

      Show
      Doug Cutting added a comment - The test looks good. Can you please combine the two patches into a single patch file, then select "Submit Patch" to trigger automated testing? Thanks! Also, the "Assignee" should stay set to the primary author of the patch, so that they retain credit for the contribution.
      Hide
      Michael Tamm added a comment -

      Attached fix_and_test_for_HADOOP-5423.patch, which contains the fix and the test.

      Show
      Michael Tamm added a comment - Attached fix_and_test_for_ HADOOP-5423 .patch, which contains the fix and the test.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12402134/fix_and_test_for_HADOOP-5423.patch
      against trunk revision 753113.

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 6 new or modified tests.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs warnings.

      +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed core unit tests.

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/62/testReport/
      Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/62/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
      Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/62/artifact/trunk/build/test/checkstyle-errors.html
      Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/62/console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12402134/fix_and_test_for_HADOOP-5423.patch against trunk revision 753113. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/62/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/62/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/62/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/62/console This message is automatically generated.
      Hide
      Chris Douglas added a comment -

      +1

      I committed this. Thanks, Michael

      Show
      Chris Douglas added a comment - +1 I committed this. Thanks, Michael
      Hide
      Hudson added a comment -
      Show
      Hudson added a comment - Integrated in Hadoop-trunk #796 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/796/ )

        People

        • Assignee:
          Michael Tamm
          Reporter:
          Michael Tamm
        • Votes:
          2 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development