Hadoop Common
  1. Hadoop Common
  2. HADOOP-5240

'ant javadoc' does not check whether outputs are up to date and always rebuilds

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: build
    • Labels:
      None

      Description

      Running 'ant javadoc' twice in a row calls the javadoc program both times; it doesn't check to see whether this is redundant work.

      1. HADOOP-5240.patch.2
        1 kB
        Aaron Kimball
      2. HADOOP-5240.patch.3
        1 kB
        Aaron Kimball
      3. patch
        2 kB
        Aaron Kimball

        Activity

        Hide
        Aaron Kimball added a comment -

        Attached patch uses a timestamp file and an <uptodate> task to determine if javadoc is necessary. "ant package" seems to update a lot of site files, though, which invalidates this, but in the general case this will speed up recompilation.

        Show
        Aaron Kimball added a comment - Attached patch uses a timestamp file and an <uptodate> task to determine if javadoc is necessary. "ant package" seems to update a lot of site files, though, which invalidates this, but in the general case this will speed up recompilation.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12400128/patch
        against trunk revision 744114.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3848/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3848/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3848/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3848/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12400128/patch against trunk revision 744114. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3848/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3848/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3848/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3848/console This message is automatically generated.
        Hide
        Aaron Kimball added a comment -

        Failing core test is org.apache.hadoop.mapred.TestTaskLimits.testTaskLimits experienced a timeout; not sure how this could be related.

        No new tests because we don't have a unit test framework for the buildfile itself.

        Show
        Aaron Kimball added a comment - Failing core test is org.apache.hadoop.mapred.TestTaskLimits.testTaskLimits experienced a timeout; not sure how this could be related. No new tests because we don't have a unit test framework for the buildfile itself.
        Hide
        Doug Cutting added a comment -

        A few questions:

        • rather than excluding specific files, why not include just *.java and *.html, since these are all that normally wind up in javadoc.
        • rather than writing a timestamp file, why not use the index.html that javadoc generates?
        Show
        Doug Cutting added a comment - A few questions: rather than excluding specific files, why not include just *.java and *.html, since these are all that normally wind up in javadoc. rather than writing a timestamp file, why not use the index.html that javadoc generates?
        Hide
        Aaron Kimball added a comment -

        Good points, Doug. Updated patch.

        Show
        Aaron Kimball added a comment - Good points, Doug. Updated patch.
        Hide
        Doug Cutting added a comment -

        I just committed this. Thanks, Aaron.

        Show
        Doug Cutting added a comment - I just committed this. Thanks, Aaron.
        Hide
        Aaron Kimball added a comment -

        I realized that I submitted this for -p1, not -p0. This version has the fix. Sorry about that :\

        Show
        Aaron Kimball added a comment - I realized that I submitted this for -p1, not -p0. This version has the fix. Sorry about that :\
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #766 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/766/ )

          People

          • Assignee:
            Aaron Kimball
            Reporter:
            Aaron Kimball
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development