Hadoop Common
  1. Hadoop Common
  2. HADOOP-5229

duplicate variables in build.xml hadoop.version vs version let build fails at assert-hadoop-jar-exists

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      <property name="hadoop.jar" location="$

      {build.dir}/hadoop-${hadoop.version}-core.jar" /> where hadoop.version is defined in ${ivy.dir}/libraries.properties as hadoop.version=0.20.0.
      Though <jar jarfile="${build.dir}

      /$

      {final.name}

      -core.jar" where <property name="final.name" value="$

      {name}

      -$

      {version}

      "/>.
      Means there is a hadoop-0.21.0-dev-core.jar builded though the assert-hadoop-jar-exists target looks for a hadoop-0.2.0-core.jar.

        Activity

        Hide
        Stefan Groschupf added a comment -

        also the version number is inconsitent use in the ivy.xml what generate pom files with placeholder version number (working@host).

        Show
        Stefan Groschupf added a comment - also the version number is inconsitent use in the ivy.xml what generate pom files with placeholder version number (working@host).
        Hide
        Stefan Groschupf added a comment -

        fixes the problem of duplicate variables with different values for the same thing and fixes the broken ivy deploy and makepom targets.

        Show
        Stefan Groschupf added a comment - fixes the problem of duplicate variables with different values for the same thing and fixes the broken ivy deploy and makepom targets.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12400113/HADOOP-5229-v1-sg.patch
        against trunk revision 744000.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3846/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3846/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3846/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3846/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12400113/HADOOP-5229-v1-sg.patch against trunk revision 744000. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3846/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3846/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3846/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3846/console This message is automatically generated.
        Hide
        Stefan Groschupf added a comment -

        > -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch.
        hmm how to test the build scripts? Is there something that can do something like this?

        Show
        Stefan Groschupf added a comment - > -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. hmm how to test the build scripts? Is there something that can do something like this?
        Hide
        Johan Oskarsson added a comment -

        I just committed this. Thanks Stefan!

        Show
        Johan Oskarsson added a comment - I just committed this. Thanks Stefan!
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #778 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/778/ )

          People

          • Assignee:
            Stefan Groschupf
            Reporter:
            Stefan Groschupf
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development