Hadoop Common
  1. Hadoop Common
  2. HADOOP-5226

Add license headers to html and jsp files

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: documentation
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      License headers are missing in some html and jsp files.

      1. 5226_20090212.patch
        38 kB
        Tsz Wo Nicholas Sze

        Activity

        Tsz Wo Nicholas Sze created issue -
        Hide
        Tsz Wo Nicholas Sze added a comment -

        5226_20090212.patch: added license headers.

        Show
        Tsz Wo Nicholas Sze added a comment - 5226_20090212.patch: added license headers.
        Tsz Wo Nicholas Sze made changes -
        Field Original Value New Value
        Attachment 5226_20090212.patch [ 12400129 ]
        Hide
        Jakob Homan added a comment -

        At lines 731 and 274 it looks like diff might have got a bit confused and lost an extra line, which would end up without the spacing in the license. Otherwise +1

        Show
        Jakob Homan added a comment - At lines 731 and 274 it looks like diff might have got a bit confused and lost an extra line, which would end up without the spacing in the license. Otherwise +1
        Hide
        Tsz Wo Nicholas Sze added a comment -

        > At lines 731 and 274 it looks like diff might have got a bit confused and lost an extra line ..

        There was a empty line in the source. So diff is correct to keep the original empty line and add the license from above and below.

        Thanks, Jakob.

        Show
        Tsz Wo Nicholas Sze added a comment - > At lines 731 and 274 it looks like diff might have got a bit confused and lost an extra line .. There was a empty line in the source. So diff is correct to keep the original empty line and add the license from above and below. Thanks, Jakob.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        This is an obvious documentation changes. I committed this without submitting to Hudson.

        Show
        Tsz Wo Nicholas Sze added a comment - This is an obvious documentation changes. I committed this without submitting to Hudson.
        Tsz Wo Nicholas Sze made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Assignee Tsz Wo (Nicholas), SZE [ szetszwo ]
        Fix Version/s 0.21.0 [ 12313563 ]
        Hadoop Flags [Reviewed]
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #756 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/756/ )
        Tom White made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        1d 1h 7m 1 Tsz Wo Nicholas Sze 12/Feb/09 22:26
        Resolved Resolved Closed Closed
        557d 22h 9m 1 Tom White 24/Aug/10 21:35

          People

          • Assignee:
            Tsz Wo Nicholas Sze
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development