Hadoop Common
  1. Hadoop Common
  2. HADOOP-5206

All "unprotected*" methods of FSDirectory should synchronize on the root.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.20.0
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Synchronization on rootDir is missing for two (relatively new) methods:

      • unprotectedSetQuota()
      • unprotectedSetTimes()

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-trunk #758 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/758/)
        . Synchronize "unprotected*" methods of FSDirectory on the root. Contributed by Jakob Homan.

        Show
        Hudson added a comment - Integrated in Hadoop-trunk #758 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/758/ ) . Synchronize "unprotected*" methods of FSDirectory on the root. Contributed by Jakob Homan.
        Hide
        Konstantin Shvachko added a comment -

        I just committed this. Thank you Jakob.

        Show
        Konstantin Shvachko added a comment - I just committed this. Thank you Jakob.
        Hide
        Jakob Homan added a comment -

        Failing contrib test is known bad. Tests -1 explained above.

        Show
        Jakob Homan added a comment - Failing contrib test is known bad. Tests -1 explained above.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12400037/HADOOP-5206.patch
        against trunk revision 743513.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3836/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3836/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3836/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3836/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12400037/HADOOP-5206.patch against trunk revision 743513. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3836/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3836/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3836/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3836/console This message is automatically generated.
        Hide
        Jakob Homan added a comment -

        Submitting patch.

        Show
        Jakob Homan added a comment - Submitting patch.
        Hide
        Jakob Homan added a comment -

        Patch fixes the two instances Konstantin mentioned. Also scanned through the class to make sure there were no others. All unit tests pass except known-bad HADOOP-4907.

             [exec] -1 overall.  
             [exec] 
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec] 
             [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
             [exec]                         Please justify why no tests are needed for this patch.
             [exec] 
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec] 
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec] 
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
             [exec] 
             [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
             [exec] 
             [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
        

        No new unit test as is synchronization fix and not easily testable.

        Show
        Jakob Homan added a comment - Patch fixes the two instances Konstantin mentioned. Also scanned through the class to make sure there were no others. All unit tests pass except known-bad HADOOP-4907 . [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. No new unit test as is synchronization fix and not easily testable.

          People

          • Assignee:
            Jakob Homan
            Reporter:
            Konstantin Shvachko
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development