Hadoop Common
  1. Hadoop Common
  2. HADOOP-5205

Change CHUKWA_IDENT_STRING from "demo" to "TODO-AGENTS-INSTANCE-NAME"

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    1. HADOOP-5205.patch
      0.5 kB
      Jerome Boulon

      Activity

      Hide
      Jerome Boulon added a comment -

      Change the value of CHUKWA_IDENT_STRING from demo to TODO-AGENTS-INSTANCE-NAME in chukwa-env.sh.template

      Show
      Jerome Boulon added a comment - Change the value of CHUKWA_IDENT_STRING from demo to TODO-AGENTS-INSTANCE-NAME in chukwa-env.sh.template
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12399851/HADOOP-5205.patch
      against trunk revision 742698.

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no tests are needed for this patch.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs warnings.

      +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed core unit tests.

      -1 contrib tests. The patch failed contrib unit tests.

      Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3821/testReport/
      Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3821/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
      Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3821/artifact/trunk/build/test/checkstyle-errors.html
      Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3821/console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12399851/HADOOP-5205.patch against trunk revision 742698. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3821/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3821/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3821/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3821/console This message is automatically generated.
      Hide
      Jerome Boulon added a comment -

      -1 contrib tests. failed contrib unit tests is not related to this patch

      Show
      Jerome Boulon added a comment - -1 contrib tests. failed contrib unit tests is not related to this patch
      Hide
      Ari Rabkin added a comment -

      it's not obvious to me that that's the right default, but I don't see any harm in it. +1

      Show
      Ari Rabkin added a comment - it's not obvious to me that that's the right default, but I don't see any harm in it. +1
      Hide
      Ari Rabkin added a comment -

      I just committed this; thanks Jerome!

      [this is my first time committing something; let me know if I do/did something wrong]

      Show
      Ari Rabkin added a comment - I just committed this; thanks Jerome! [this is my first time committing something; let me know if I do/did something wrong]
      Hide
      Hudson added a comment -

      Integrated in Hadoop-trunk #766 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/766/)
      , change to default CHUKWA_IDENT_STRING
      Submitted by: Jerome Boulon (jboulon)

      Show
      Hudson added a comment - Integrated in Hadoop-trunk #766 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/766/ ) , change to default CHUKWA_IDENT_STRING Submitted by: Jerome Boulon (jboulon)

        People

        • Assignee:
          Jerome Boulon
          Reporter:
          Jerome Boulon
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development