Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The Chukwa bin scripts refer to conf/slaves. This should be conf/chukwa-agents.
      Further, stop-agents should not touch cron, since start-agents doesn't.

      1. betterbin.patch
        0.9 kB
        Ari Rabkin

        Activity

        Hide
        Robert Chansler added a comment -

        Editorial pass over all release notes prior to publication of 0.21. Routine.

        Show
        Robert Chansler added a comment - Editorial pass over all release notes prior to publication of 0.21. Routine.
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #756 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/756/ )
        Hide
        Chris Douglas added a comment -

        I committed this. Thanks, Ari

        Show
        Chris Douglas added a comment - I committed this. Thanks, Ari
        Hide
        Andy Konwinski added a comment -

        +1 the shell script should have been named this way in the first place

        Show
        Andy Konwinski added a comment - +1 the shell script should have been named this way in the first place
        Hide
        Eric Yang added a comment -

        +1 filename change in shell script. This change makes the file name more clearly defined.

        Show
        Eric Yang added a comment - +1 filename change in shell script. This change makes the file name more clearly defined.
        Hide
        Ari Rabkin added a comment -

        previous patch was against $CHUKWA_HOME, not against Hadoop rootdir. This

        Show
        Ari Rabkin added a comment - previous patch was against $CHUKWA_HOME, not against Hadoop rootdir. This
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12399096/betterbin.patch
        against trunk revision 739416.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3782/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12399096/betterbin.patch against trunk revision 739416. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3782/console This message is automatically generated.
        Hide
        Ari Rabkin added a comment -

        no tests for bin scripts

        Show
        Ari Rabkin added a comment - no tests for bin scripts

          People

          • Assignee:
            Ari Rabkin
            Reporter:
            Ari Rabkin
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development