Hadoop Common
  1. Hadoop Common
  2. HADOOP-5138

Current Chukwa Trunk failed contrib unit tests.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None

      Description

      junit.framework.AssertionFailedError: org.apache.hadoop.chukwa.datacollection.agent.ChukwaAgent$AlreadyRunningException: Agent already running; aborting
      at org.apache.hadoop.chukwa.datacollection.agent.TestAgentConfig.testInitAdaptors_vs_Checkpoint(TestAgentConfig.java:73)

      Test org.apache.hadoop.chukwa.datacollection.adaptor.filetailer.TestStartAtOffset FAILED (timeout)

      1. HADOOP-5138.patch
        6 kB
        Jerome Boulon

        Issue Links

          Activity

          Hide
          Ari Rabkin added a comment -

          I think HADOOP-4947 isn't quite right – in fact, neither HADOOP-5087 nor HADOOP-4947 is quite right; I checked both.

          Show
          Ari Rabkin added a comment - I think HADOOP-4947 isn't quite right – in fact, neither HADOOP-5087 nor HADOOP-4947 is quite right; I checked both.
          Hide
          Ari Rabkin added a comment -

          Submitted a revised patch for HADOOP-5087; this one removes trailing spaces from adapter params. This should fix the TestStartAtOffset errors.

          Show
          Ari Rabkin added a comment - Submitted a revised patch for HADOOP-5087 ; this one removes trailing spaces from adapter params. This should fix the TestStartAtOffset errors.
          Hide
          Jerome Boulon added a comment -

          Fixes:

          • FileTailingAdaptor.java: remove trailing spaces on the fileName
          • ChukwaAgent.java: Fix regex to be able to parse a valid checkpoint (cf HADOOP-5087)
          • ConstRateAdaptor.java: output the right information so the agent can generate a valid chekpoint
          • TestCharFileTailingAdaptorUTF8.java: CharFileTailingAdaptorUTF8 test case
          Show
          Jerome Boulon added a comment - Fixes: FileTailingAdaptor.java: remove trailing spaces on the fileName ChukwaAgent.java: Fix regex to be able to parse a valid checkpoint (cf HADOOP-5087 ) ConstRateAdaptor.java: output the right information so the agent can generate a valid chekpoint TestCharFileTailingAdaptorUTF8.java: CharFileTailingAdaptorUTF8 test case
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12399022/HADOOP-5138.patch
          against trunk revision 739416.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3777/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3777/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3777/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3777/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12399022/HADOOP-5138.patch against trunk revision 739416. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3777/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3777/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3777/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3777/console This message is automatically generated.
          Hide
          Eric Yang added a comment -

          Separating TestCharFileTailing and TestFileTailing adaptor is a good workaround to ensure the queue isn't reused between two instance of the ChukwaAgent. +1 to this patch.

          Show
          Eric Yang added a comment - Separating TestCharFileTailing and TestFileTailing adaptor is a good workaround to ensure the queue isn't reused between two instance of the ChukwaAgent. +1 to this patch.
          Hide
          Arun C Murthy added a comment -

          I just committed this. Thanks, Jerome!

          Show
          Arun C Murthy added a comment - I just committed this. Thanks, Jerome!
          Hide
          Hudson added a comment -
          Show
          Hudson added a comment - Integrated in Hadoop-trunk #756 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/756/ )

            People

            • Assignee:
              Jerome Boulon
              Reporter:
              Jerome Boulon
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development