Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-5057

Chukwa agent crash on startup with missing check point file

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Environment:

      Redhat 5.1, Java 6

    • Hadoop Flags:
      Reviewed

      Description

      When check point file doesn't exist, the agent startup script crashes.

        Activity

        Hide
        asrabkin Ari Rabkin added a comment -

        The script, or the agent java code? The scripts shouldn't be looking at checkpoints, and the agent really shouldn't crash there...can you say mre?

        Show
        asrabkin Ari Rabkin added a comment - The script, or the agent java code? The scripts shouldn't be looking at checkpoints, and the agent really shouldn't crash there...can you say mre?
        Hide
        eyang Eric Yang added a comment -

        It's the java code. When the program is doing a directory listing of check point file, and the result is null. It throws a null pointer exception.

        Show
        eyang Eric Yang added a comment - It's the java code. When the program is doing a directory listing of check point file, and the result is null. It throws a null pointer exception.
        Hide
        asrabkin Ari Rabkin added a comment -

        I can't reproduce the problem, but this patch at least improves our test coverage. Checks four cases:
        no checkpoint dir, empty checkpoint dir, zero-length checkpoint file, valid checkpoint file.

        Show
        asrabkin Ari Rabkin added a comment - I can't reproduce the problem, but this patch at least improves our test coverage. Checks four cases: no checkpoint dir, empty checkpoint dir, zero-length checkpoint file, valid checkpoint file.
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12401269/checkpoint_cleanup.patch
        against trunk revision 749863.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 8 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/42/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/42/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/42/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/42/console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12401269/checkpoint_cleanup.patch against trunk revision 749863. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 8 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/42/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/42/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/42/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/42/console This message is automatically generated.
        Hide
        eyang Eric Yang added a comment -

        +1 looks good. This bug was created for checking checkpointNames==null case in ChukwaAgent. This problem has been resolved earlier. This patch added more to our test cases, which is good.

        Show
        eyang Eric Yang added a comment - +1 looks good. This bug was created for checking checkpointNames==null case in ChukwaAgent. This problem has been resolved earlier. This patch added more to our test cases, which is good.
        Hide
        asrabkin Ari Rabkin added a comment -

        I just committed this.

        Show
        asrabkin Ari Rabkin added a comment - I just committed this.
        Hide
        hudson Hudson added a comment -
        Show
        hudson Hudson added a comment - Integrated in Hadoop-trunk #778 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/778/ )

          People

          • Assignee:
            asrabkin Ari Rabkin
            Reporter:
            eyang Eric Yang
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development