Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Starting the agent using the chuka-daemon.sh script redirect the standard output to a file. Only critical information should be outputted to stdout

      1. HADOOP-5038-2.patch
        0.8 kB
        Jerome Boulon
      2. HADOOP-5038.patch2
        0.8 kB
        Jerome Boulon
      3. HADOOP-5038.patch2
        0.8 kB
        Jerome Boulon
      4. HADOOP-5038.patch
        1 kB
        Jerome Boulon

        Issue Links

          Activity

          Hide
          Jerome Boulon added a comment -

          Replace System.out.println by log.debug

          Show
          Jerome Boulon added a comment - Replace System.out.println by log.debug
          Hide
          Eric Yang added a comment -

          +1 looks good, this patch would reduce a lot of output to .out file.

          Show
          Eric Yang added a comment - +1 looks good, this patch would reduce a lot of output to .out file.
          Hide
          Ari Rabkin added a comment - - edited

          The goal is certainly a good one.

          I have one hesitation though – Given this patch, the HTTP response will never get read. I'm nervous that in a long-running connection, a buffer associated with the socket will fill up, and writes will block. Are you confident that won't happen? Do we have tests to cover long running large-data transfers, and in particular ones across the network?

          Show
          Ari Rabkin added a comment - - edited The goal is certainly a good one. I have one hesitation though – Given this patch, the HTTP response will never get read. I'm nervous that in a long-running connection, a buffer associated with the socket will fill up, and writes will block. Are you confident that won't happen? Do we have tests to cover long running large-data transfers, and in particular ones across the network?
          Hide
          Jerome Boulon added a comment -

          The issue brings by Ari should not happen since the HTTP response will contains just a few characters but to be cleaner this patch always reads response and print only on debug mode.

          Show
          Jerome Boulon added a comment - The issue brings by Ari should not happen since the HTTP response will contains just a few characters but to be cleaner this patch always reads response and print only on debug mode.
          Hide
          Mac Yang added a comment -

          +1

          Show
          Mac Yang added a comment - +1
          Hide
          Jerome Boulon added a comment -

          Junit failed because of HADOOP-5138

          Show
          Jerome Boulon added a comment - Junit failed because of HADOOP-5138
          Hide
          Jerome Boulon added a comment -

          upload the patch again so that it could be picked up by Hudson

          Show
          Jerome Boulon added a comment - upload the patch again so that it could be picked up by Hudson
          Hide
          Eric Yang added a comment -

          Please use extension .patch, otherwise hudson will not be able to detect the file type.

          Show
          Eric Yang added a comment - Please use extension .patch, otherwise hudson will not be able to detect the file type.
          Hide
          Chris Douglas added a comment -

          I committed this. Thanks, Jerome

          Show
          Chris Douglas added a comment - I committed this. Thanks, Jerome
          Hide
          Hudson added a comment -
          Show
          Hudson added a comment - Integrated in Hadoop-trunk #756 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/756/ )

            People

            • Assignee:
              Jerome Boulon
              Reporter:
              Jerome Boulon
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development