Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-5035

Support non Time Series charting and handle data gap more gracefully for Chukwa charts

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Duplicate
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Environment:

      RedHat 5.1, Java 6

    • Hadoop Flags:
      Reviewed

      Description

      Chukwa charting only support time series data because the data structure is a HashMap of Long, Double.
      Long is the timestamp (xaxis), and Double is the yaxis value. The data structure will be changed to HashMap of String, Double.
      This will add capability to plot xaxis with any data.

      If the yaxis value is not a number, the charting system should skip plotting for this data point.

        Activity

        Hide
        hudson Hudson added a comment -
        Show
        hudson Hudson added a comment - Integrated in Hadoop-trunk #778 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/778/ )
        Hide
        eyang Eric Yang added a comment -

        The code has been checked in. Resolve as duplicate.

        Show
        eyang Eric Yang added a comment - The code has been checked in. Resolve as duplicate.
        Hide
        eyang Eric Yang added a comment -

        The patch is already in trunk.

        Show
        eyang Eric Yang added a comment - The patch is already in trunk.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12398034/HADOOP-5035.patch
        against trunk revision 749318.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/35/console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12398034/HADOOP-5035.patch against trunk revision 749318. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/35/console This message is automatically generated.
        Hide
        gkesavan Giridharan Kesavan added a comment -

        reopening and resubmitting the patch to hudson, bcoz the patch didn't go well with hudson as the status is set to resolved.

        Show
        gkesavan Giridharan Kesavan added a comment - reopening and resubmitting the patch to hudson, bcoz the patch didn't go well with hudson as the status is set to resolved.
        Hide
        eyang Eric Yang added a comment -

        For graph that reporting numbers between 1000 and 2000, we would like to show the full numbers instead of x*10^3 because this makes indentation look nicer for the Y axis ticker labels.

        Show
        eyang Eric Yang added a comment - For graph that reporting numbers between 1000 and 2000, we would like to show the full numbers instead of x*10^3 because this makes indentation look nicer for the Y axis ticker labels.
        Hide
        jboulon Jerome Boulon added a comment -

        Could you fix the indentention and put a comment on why you are doing "else if (val >= 2000) return (val / 1000).toFixed(2) + \"x10<sup>3</sup>\";"
        It's not obvious why 2000 and not 1000
        Other than that the patch looks good.

        Show
        jboulon Jerome Boulon added a comment - Could you fix the indentention and put a comment on why you are doing "else if (val >= 2000) return (val / 1000).toFixed(2) + \"x10<sup>3</sup>\";" It's not obvious why 2000 and not 1000 Other than that the patch looks good.
        Hide
        eyang Eric Yang added a comment -
        • Improved Y axis ticker labelling.
        • Used TreeMap to build non-time series data for charting.
        • Improved handling of "not a number "values.
        Show
        eyang Eric Yang added a comment - Improved Y axis ticker labelling. Used TreeMap to build non-time series data for charting. Improved handling of "not a number "values.

          People

          • Assignee:
            eyang Eric Yang
            Reporter:
            eyang Eric Yang
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development