Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Removed deprecated method FileSystem.delete(Path).

      Description

      Remove the following:

        /** Delete a file. */
        /** @deprecated Use delete(Path, boolean) instead */ @Deprecated 
        public abstract boolean delete(Path f) throws IOException;
      
      1. remove-fs-delete_v2.patch
        34 kB
        Enis Soztutar
      2. remove-fs-delete_v1.patch
        42 kB
        Enis Soztutar

        Issue Links

          Activity

          Tsz Wo Nicholas Sze created issue -
          Enis Soztutar made changes -
          Field Original Value New Value
          Assignee Enis Soztutar [ enis ]
          Hide
          Enis Soztutar added a comment -

          Attaching a patch which is a combination of 4779_20081218.patch and hadoop-4779-remaining_v1.patch at HADOOP-4779.

          Show
          Enis Soztutar added a comment - Attaching a patch which is a combination of 4779_20081218.patch and hadoop-4779-remaining_v1.patch at HADOOP-4779 .
          Enis Soztutar made changes -
          Attachment remove-fs-delete_v1.patch [ 12396772 ]
          Enis Soztutar made changes -
          Affects Version/s 0.21.0 [ 12313563 ]
          Hadoop Flags [Incompatible change]
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          +1 patch looks good.

          Show
          Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
          Tsz Wo Nicholas Sze made changes -
          Release Note Remove a deprecated method, FileSystem.delete(Path, boolean).
          Fix Version/s 0.21.0 [ 12313563 ]
          Hadoop Flags [Incompatible change] [Incompatible change, Reviewed]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Enis, the patch cannot be applied, could you update it?

          Show
          Tsz Wo Nicholas Sze added a comment - Enis, the patch cannot be applied, could you update it?
          Hide
          Enis Soztutar added a comment -

          Updated patch to trunk.

          Show
          Enis Soztutar added a comment - Updated patch to trunk.
          Enis Soztutar made changes -
          Attachment remove-fs-delete_v2.patch [ 12397410 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -
               [exec] +1 overall.  
               [exec] 
               [exec]     +1 @author.  The patch does not contain any @author tags.
               [exec] 
               [exec]     +1 tests included.  The patch appears to include 21 new or modified tests.
               [exec] 
               [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
               [exec] 
               [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
               [exec] 
               [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
               [exec] 
               [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
          
          Show
          Tsz Wo Nicholas Sze added a comment - [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 21 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          All tests passed except the known failing TestMapReduceLocal (HADOOP-4907). I tried ant tar, ant compile-native ..., etc. everything can be compiled.

          I just committed this. Thanks, Enis!

          Show
          Tsz Wo Nicholas Sze added a comment - All tests passed except the known failing TestMapReduceLocal ( HADOOP-4907 ). I tried ant tar, ant compile-native ..., etc. everything can be compiled. I just committed this. Thanks, Enis!
          Tsz Wo Nicholas Sze made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed, Incompatible change] [Incompatible change, Reviewed]
          Resolution Fixed [ 1 ]
          Cyrus Katrak made changes -
          Link This issue relates to HIVE-841 [ HIVE-841 ]
          Hide
          Robert Chansler added a comment -

          Editorial pass over all release notes prior to publication of 0.21.

          Show
          Robert Chansler added a comment - Editorial pass over all release notes prior to publication of 0.21.
          Robert Chansler made changes -
          Release Note Remove a deprecated method, FileSystem.delete(Path, boolean). Removed deprecated method FileSystem.delete(Path, boolean).
          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Tsz Wo Nicholas Sze made changes -
          Release Note Removed deprecated method FileSystem.delete(Path, boolean). Removed deprecated method FileSystem.delete(Path).

            People

            • Assignee:
              Enis Soztutar
              Reporter:
              Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development