Hadoop Common
  1. Hadoop Common
  2. HADOOP-4778

Check for zero size block meta file when updating a block.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.18.3
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In case of datanode running out of disk space, block meta files may be created with zero length. We should detect this obvious problem when updating a block.

      1. 4778_20081204_0.18.patch
        0.6 kB
        Tsz Wo Nicholas Sze
      2. 4778_20081204.patch
        0.7 kB
        Tsz Wo Nicholas Sze

        Activity

        Hide
        Tsz Wo Nicholas Sze added a comment -

        4769_20081203.patch: Check for zero size block meta file.

        Show
        Tsz Wo Nicholas Sze added a comment - 4769_20081203.patch: Check for zero size block meta file.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        4778_20081204.patch: should be this file.

        Show
        Tsz Wo Nicholas Sze added a comment - 4778_20081204.patch: should be this file.
        Hide
        Tsz Wo Nicholas Sze added a comment -
             [exec] -1 overall.  
        
             [exec]     +1 @author.  The patch does not contain any @author tags.
        
             [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
             [exec]                         Please justify why no tests are needed for this patch.
        
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
        
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
        
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
        
             [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
        

        The change is trivial. No new tests added.

        Show
        Tsz Wo Nicholas Sze added a comment - [exec] -1 overall. [exec] +1 @author. The patch does not contain any @author tags. [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. The change is trivial. No new tests added.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Passed all tests locally.

        Show
        Tsz Wo Nicholas Sze added a comment - Passed all tests locally.
        Hide
        Hairong Kuang added a comment -

        +1

        Show
        Hairong Kuang added a comment - +1
        Hide
        Tsz Wo Nicholas Sze added a comment -

        4778_20081204_0.18.patch: for 0.18

        Show
        Tsz Wo Nicholas Sze added a comment - 4778_20081204_0.18.patch: for 0.18
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I just committed this.

        Show
        Tsz Wo Nicholas Sze added a comment - I just committed this.
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #680 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/680/ )

          People

          • Assignee:
            Tsz Wo Nicholas Sze
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development