Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.18.2
    • Fix Version/s: 0.18.3
    • Component/s: documentation
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Try searching "the the" in the documentation files. See http://issues.apache.org/jira/browse/HADOOP-4704?focusedCommentId=12649589#action_12649589 for a list.

      1. 4726_20081202.patch
        119 kB
        Tsz Wo Nicholas Sze
      2. HADOOP-4726_for_0.18.patch
        15 kB
        Edward J. Yoon
      3. HADOOP-4726_v02.patch
        14 kB
        Edward J. Yoon
      4. HADOOP-4726_v04.patch
        15 kB
        Edward J. Yoon
      5. HADOOP-4726.patch
        17 kB
        Edward J. Yoon

        Issue Links

          Activity

          Hide
          Edward J. Yoon added a comment -

          Here's another one typos: "intermedate" --> "intermediate"

          throw (IOException)new IOException
          ("Intermedate merge failed").initCause(e);

          Show
          Edward J. Yoon added a comment - Here's another one typos: "intermedate" --> "intermediate" throw (IOException)new IOException ("Intermedate merge failed").initCause(e);
          Hide
          Edward J. Yoon added a comment -

          I would like to work on this issue.

          Show
          Edward J. Yoon added a comment - I would like to work on this issue.
          Hide
          Edward J. Yoon added a comment -

          ugh, what is HADOOP-4704 different from this? bug report seems duplicated.

          Show
          Edward J. Yoon added a comment - ugh, what is HADOOP-4704 different from this? bug report seems duplicated.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          HADOOP-4704 is for javadoc. This one is for forrest doc and other documentation like hadoop-default.html.

          Show
          Tsz Wo Nicholas Sze added a comment - HADOOP-4704 is for javadoc. This one is for forrest doc and other documentation like hadoop-default.html.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Do you still want to work on this, Edward?

          Show
          Tsz Wo Nicholas Sze added a comment - Do you still want to work on this, Edward?
          Hide
          Edward J. Yoon added a comment -

          Oh, OK. Let me work on it.

          Show
          Edward J. Yoon added a comment - Oh, OK. Let me work on it.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Thanks, Edward.

          Show
          Tsz Wo Nicholas Sze added a comment - Thanks, Edward.
          Hide
          Edward J. Yoon added a comment -

          Attach my patch.

          Show
          Edward J. Yoon added a comment - Attach my patch.
          Hide
          Edward J. Yoon added a comment -

          Submitting.

          Show
          Edward J. Yoon added a comment - Submitting.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          +1 patch looks good. Could you also post corresponding patches for 0.18 and 0.19?

          Show
          Tsz Wo Nicholas Sze added a comment - +1 patch looks good. Could you also post corresponding patches for 0.18 and 0.19?
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12394719/HADOOP-4726.patch
          against trunk revision 721415.

          +1 @author. The patch does not contain any @author tags.

          +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3665/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3665/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3665/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3665/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12394719/HADOOP-4726.patch against trunk revision 721415. +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3665/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3665/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3665/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3665/console This message is automatically generated.
          Hide
          Edward J. Yoon added a comment -

          >> Could you also post corresponding patches for 0.18 and 0.19?

          Oh, yes. Let's apply it to the 0.18.3

          Show
          Edward J. Yoon added a comment - >> Could you also post corresponding patches for 0.18 and 0.19? Oh, yes. Let's apply it to the 0.18.3
          Hide
          Edward J. Yoon added a comment -

          re-attach the patch for 0.18.3-dev

          Show
          Edward J. Yoon added a comment - re-attach the patch for 0.18.3-dev
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Hi Edward, HADOOP-4726_for_0.18.patch cannot be applied to 0.18. Could you check that?

          Show
          Tsz Wo Nicholas Sze added a comment - Hi Edward, HADOOP-4726 _for_0.18.patch cannot be applied to 0.18. Could you check that?
          Hide
          Edward J. Yoon added a comment -

          Oh, sorry. the previous patch is clearly wrong.
          please try this patch.


          [root@udanax hadoop-0.18]# patch -p0 < HADOOP-4726_v02.patch
          patching file conf/hadoop-default.xml
          patching file docs/jdiff/hadoop_0.17.0.xml
          patching file docs/jdiff/hadoop_0.18.1.xml
          patching file docs/jdiff/hadoop_0.18.2.xml
          patching file src/docs/src/documentation/content/xdocs/cluster_setup.xml
          patching file src/docs/src/documentation/content/xdocs/hdfs_permissions_guide.xml
          patching file src/docs/src/documentation/content/xdocs/mapred_tutorial.xml
          patching file src/docs/src/documentation/content/xdocs/streaming.xml
          [root@udanax hadoop-0.18]#

          Show
          Edward J. Yoon added a comment - Oh, sorry. the previous patch is clearly wrong. please try this patch. [root@udanax hadoop-0.18] # patch -p0 < HADOOP-4726 _v02.patch patching file conf/hadoop-default.xml patching file docs/jdiff/hadoop_0.17.0.xml patching file docs/jdiff/hadoop_0.18.1.xml patching file docs/jdiff/hadoop_0.18.2.xml patching file src/docs/src/documentation/content/xdocs/cluster_setup.xml patching file src/docs/src/documentation/content/xdocs/hdfs_permissions_guide.xml patching file src/docs/src/documentation/content/xdocs/mapred_tutorial.xml patching file src/docs/src/documentation/content/xdocs/streaming.xml [root@udanax hadoop-0.18] #
          Hide
          Tsz Wo Nicholas Sze added a comment -
          • Seems there are some EOL changes in streaming.xml. It confuses svn. Tried to apply HADOOP-4726.patch (or HADOOP-4726_v02.patch) and than did "svn diff > a.patch". The resulted a.patch contained the entire streaming.xml file.
          Show
          Tsz Wo Nicholas Sze added a comment - ReduceTask.java is missing in HADOOP-4726 _v02.patch. Seems there are some EOL changes in streaming.xml. It confuses svn. Tried to apply HADOOP-4726 .patch (or HADOOP-4726 _v02.patch) and than did "svn diff > a.patch". The resulted a.patch contained the entire streaming.xml file.
          Hide
          Edward J. Yoon added a comment -

          Thanks for your review. I fixed them.


          [root@udanax hadoop-0.18]# patch -p0 < ~/Desktop/HADOOP-4726_v04.patch
          ...
          + patching file src/mapred/org/apache/hadoop/mapred/ReduceTask.java
          ...
          [root@udanax hadoop-0.18]# svn diff > a.patch
          [root@udanax hadoop-0.18]# cat a.patch

          Index: src/docs/src/documentation/content/xdocs/streaming.xml
          ===================================================================
          — src/docs/src/documentation/content/xdocs/streaming.xml (revision 722337)
          +++ src/docs/src/documentation/content/xdocs/streaming.xml (working copy)
          @@ -48,11 +48,11 @@
          ....

          Show
          Edward J. Yoon added a comment - Thanks for your review. I fixed them. [root@udanax hadoop-0.18] # patch -p0 < ~/Desktop/ HADOOP-4726 _v04.patch ... + patching file src/mapred/org/apache/hadoop/mapred/ReduceTask.java ... [root@udanax hadoop-0.18] # svn diff > a.patch [root@udanax hadoop-0.18] # cat a.patch Index: src/docs/src/documentation/content/xdocs/streaming.xml =================================================================== — src/docs/src/documentation/content/xdocs/streaming.xml (revision 722337) +++ src/docs/src/documentation/content/xdocs/streaming.xml (working copy) @@ -48,11 +48,11 @@ ....
          Hide
          Tsz Wo Nicholas Sze added a comment -

          HADOOP-4726.patch also has a eol problem in streaming.xml. I fixed it. 4726_20081202.patch is the patch committed.

          Show
          Tsz Wo Nicholas Sze added a comment - HADOOP-4726 .patch also has a eol problem in streaming.xml. I fixed it. 4726_20081202.patch is the patch committed.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I just committed this. Thanks, Edward!

          Show
          Tsz Wo Nicholas Sze added a comment - I just committed this. Thanks, Edward!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-trunk #677 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/677/)
          . Fix documentation typos "the the". (Edward J. Yoon via szetszwo)

          Show
          Hudson added a comment - Integrated in Hadoop-trunk #677 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/677/ ) . Fix documentation typos "the the". (Edward J. Yoon via szetszwo)

            People

            • Assignee:
              Edward J. Yoon
              Reporter:
              Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development