Hadoop Common
  1. Hadoop Common
  2. HADOOP-4674

hadoop fs -help should list detailed help info for the following commands: test, text, tail, stat & touchz

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.20.0
    • Fix Version/s: 0.20.1
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The "hadoop fs -help" command should include descriptive text for the commands commands: test, text, tail, stat & touchz in the default help summary.

      Seems like a matter of just adding them to the default "else" at the end of the printHelp method in the FsShell.java file.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Patch Available Patch Available Open Open
        25d 16h 31m 3 Ravi Phulari 22/Apr/09 00:30
        Open Open Patch Available Patch Available
        129d 5h 4 Ravi Phulari 22/Apr/09 01:49
        Patch Available Patch Available Resolved Resolved
        2d 16h 38m 1 Tsz Wo Nicholas Sze 24/Apr/09 18:27
        Tom White made changes -
        Fix Version/s 0.21.0 [ 12313563 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Hemanth, thanks for checking this. I've just committed this to 0.20.

        Show
        Tsz Wo Nicholas Sze added a comment - Hemanth, thanks for checking this. I've just committed this to 0.20.
        Hide
        Hemanth Yamijala added a comment -

        Nicholas, I see that this issue is marked fixed for 0.20.1, but doesn't seem to have been committed for branch 0.20 (verified from the subversion commits). I found the problem when merging CHANGES.txt between trunk and the 0.20 branch. Can you please verify ?

        Show
        Hemanth Yamijala added a comment - Nicholas, I see that this issue is marked fixed for 0.20.1, but doesn't seem to have been committed for branch 0.20 (verified from the subversion commits). I found the problem when merging CHANGES.txt between trunk and the 0.20 branch. Can you please verify ?
        Hide
        Hudson added a comment -

        Integrated in Hadoop-trunk #817 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/817/)
        . Fix fs help messages for -test, -text, -tail, -stat and -touchz options. Contributed by Ravi Phulari

        Show
        Hudson added a comment - Integrated in Hadoop-trunk #817 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/817/ ) . Fix fs help messages for -test, -text, -tail, -stat and -touchz options. Contributed by Ravi Phulari
        Tsz Wo Nicholas Sze made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this. Thanks, Ravi!

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Ravi!
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12406080/Hadoop-4674v3.patch
        against trunk revision 768073.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/235/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/235/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/235/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/235/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12406080/Hadoop-4674v3.patch against trunk revision 768073. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/235/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/235/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/235/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/235/console This message is automatically generated.
        Tsz Wo Nicholas Sze made changes -
        Hadoop Flags [Reviewed]
        Fix Version/s 0.20.1 [ 12313866 ]
        Fix Version/s 0.21.0 [ 12313563 ]
        Fix Version/s 0.20.0 [ 12313438 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 patch looks good.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
        Ravi Phulari made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Ravi Phulari added a comment -

        Updated patch for -help text .
        Thanks Nicholas.

        Show
        Ravi Phulari added a comment - Updated patch for -help text . Thanks Nicholas.
        Ravi Phulari made changes -
        Attachment Hadoop-4674v3.patch [ 12406080 ]
        Ravi Phulari made changes -
        Attachment Hadoop-4674v2.patch [ 12406072 ]
        Ravi Phulari made changes -
        Attachment Hadoop-4674.patch [ 12403786 ]
        Ravi Phulari made changes -
        Attachment Hadoop-4674.patch [ 12403787 ]
        Ravi Phulari made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Ravi Phulari made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Ravi Phulari added a comment -

        Thanks for reviewing Nicholas .
        Added help message for -text.

        Show
        Ravi Phulari added a comment - Thanks for reviewing Nicholas . Added help message for -text.
        Ravi Phulari made changes -
        Attachment Hadoop-4674v2.patch [ 12406072 ]
        Ravi Phulari made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Tsz Wo Nicholas Sze made changes -
        Hadoop Flags [Reviewed]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Look at the patch again. The help message for -text is still missing.

        Show
        Tsz Wo Nicholas Sze added a comment - Look at the patch again. The help message for -text is still missing.
        Tsz Wo Nicholas Sze made changes -
        Hadoop Flags [Reviewed]
        Assignee Ravi Phulari [ raviphulari ]
        Hide
        Tsz Wo Nicholas Sze added a comment - - edited

        +1 (see my next comment)

        Show
        Tsz Wo Nicholas Sze added a comment - - edited +1 (see my next comment)
        Hide
        Ravi Phulari added a comment -

        This patch updates hadoop fs -help . As it is a simple change did not write or modify tests for this patch.

        Show
        Ravi Phulari added a comment - This patch updates hadoop fs -help . As it is a simple change did not write or modify tests for this patch.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12403787/Hadoop-4674.patch
        against trunk revision 759398.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/74/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/74/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/74/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/74/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12403787/Hadoop-4674.patch against trunk revision 759398. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/74/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/74/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/74/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/74/console This message is automatically generated.
        Ravi Phulari made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Ravi Phulari added a comment -

        Submitting patch.

        Show
        Ravi Phulari added a comment - Submitting patch.
        Ravi Phulari made changes -
        Attachment Hadoop-4674.patch [ 12403787 ]
        Ravi Phulari made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Ravi Phulari made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Affects Version/s 0.20.0 [ 12313438 ]
        Fix Version/s 0.20.0 [ 12313438 ]
        Hide
        Ravi Phulari added a comment -

        Submitting patch .

        Show
        Ravi Phulari added a comment - Submitting patch .
        Ravi Phulari made changes -
        Field Original Value New Value
        Attachment Hadoop-4674.patch [ 12403786 ]
        David NeSmith created issue -

          People

          • Assignee:
            Ravi Phulari
            Reporter:
            David NeSmith
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development