For example, in http://hadoop.apache.org/core/docs/r0.17.2/hdfs_user_guide.html, the setSafeMode() link is pointing to http ://hadoop.apache.org/core/docs/current/..., which is not an 0.17 doc.
Broken link in Safemode documentation
These should be replaced in the xml source with relative links to api/org/apache/hadoop/...
The setSafeMode() link indeed is a missing link, instead of a broken link, since the hdfs api docs are not available in the public web site. Similarly, links to HDFS Java API do not exist.
4626_20090526.patch: fix API version.
The setSafeMode() link will be fixed in HADOOP-5918.
[exec] -1 overall.
[exec] +1 @author. The patch does not contain any @author tags.
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
This is a documentation change. No sure why "ant test-patch" cannot detect it but -1 on tests included.
I checked the generated doc manually. The links are correct.
Generated doc manually and verified for link correctness. Patch looks good.
I have committed this to 0.20 and above.