Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-4572

INode and its sub-classes should be package private

        Details

        • Type: Improvement
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 0.20.0
        • Component/s: None
        • Labels:
          None
        • Hadoop Flags:
          Incompatible change, Reviewed
        • Release Note:
          Moved org.apache.hadoop.hdfs.{CreateEditsLog, NNThroughputBenchmark} to org.apache.hadoop.hdfs.server.namenode.

          Description

          INode, INodeFile, INodeDirectory and INodeFileUnderConstruction should be changed from public to package private. As a consequence, some test classes like CreateEditsLog have to be moved to org.apache.hadoop.hdfs.server.namenode.

          1. Text File
            4572_20081103.patch
            115 kB
            Tsz Wo Nicholas Sze
          2. File
            svn_move.sh
            1 kB
            Tsz Wo Nicholas Sze

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            szetszwo Tsz Wo Nicholas Sze added a comment -

            4572_20081103.patch:

            • changed INode, INodeFile, INodeDirectory and INodeFileUnderConstruction to package private.
            • moved TestNNThroughputBenchmark, FileNameGenerator, CreateEditsLog and NNThroughputBenchmark to org.apache.hadoop.hdfs.server.namenode.
            Show
            szetszwo Tsz Wo Nicholas Sze added a comment - 4572_20081103.patch: changed INode, INodeFile, INodeDirectory and INodeFileUnderConstruction to package private. moved TestNNThroughputBenchmark, FileNameGenerator, CreateEditsLog and NNThroughputBenchmark to org.apache.hadoop.hdfs.server.namenode.
            Hide
            Permalink
            shv Konstantin Shvachko added a comment -

            +1 This looks good.

            Show
            shv Konstantin Shvachko added a comment - +1 This looks good.
            Hide
            Permalink
            hadoopqa Hadoop QA added a comment -

            +1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12393273/4572_20081103.patch
            against trunk revision 711482.

            +1 @author. The patch does not contain any @author tags.

            +1 tests included. The patch appears to include 24 new or modified tests.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 findbugs. The patch does not introduce any new Findbugs warnings.

            +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

            +1 core tests. The patch passed core unit tests.

            +1 contrib tests. The patch passed contrib unit tests.

            Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3531/testReport/
            Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3531/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
            Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3531/artifact/trunk/build/test/checkstyle-errors.html
            Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3531/console

            This message is automatically generated.

            Show
            hadoopqa Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12393273/4572_20081103.patch against trunk revision 711482. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 24 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3531/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3531/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3531/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3531/console This message is automatically generated.
            Hide
            Permalink
            szetszwo Tsz Wo Nicholas Sze added a comment -

            svn_move.sh: a script for moving the source files.

            Show
            szetszwo Tsz Wo Nicholas Sze added a comment - svn_move.sh: a script for moving the source files.
            Hide
            Permalink
            szetszwo Tsz Wo Nicholas Sze added a comment -

            I just committed this.

            Show
            szetszwo Tsz Wo Nicholas Sze added a comment - I just committed this.
            Hide
            Permalink
            hudson Hudson added a comment -

            Integrated in Hadoop-trunk #653 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/653/)
            . Change INode and its sub-classes to package private. (szetszwo)

            Show
            hudson Hudson added a comment - Integrated in Hadoop-trunk #653 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/653/ ) . Change INode and its sub-classes to package private. (szetszwo)
            Hide
            Permalink
            hudson Hudson added a comment -

            Integrated in Hadoop-Common-trunk-Commit #2632 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2632/)
            HADOOP-4572. Can not access user logs - Jetty is not configured by default to serve aliases/symlinks (ahmed via tucu) (Revision 1376753)

            Result = SUCCESS
            tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376753
            Files :

            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
            Show
            hudson Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2632 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2632/ ) HADOOP-4572 . Can not access user logs - Jetty is not configured by default to serve aliases/symlinks (ahmed via tucu) (Revision 1376753) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376753 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
            Hide
            Permalink
            hudson Hudson added a comment -

            Integrated in Hadoop-Hdfs-trunk-Commit #2696 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2696/)
            HADOOP-4572. Can not access user logs - Jetty is not configured by default to serve aliases/symlinks (ahmed via tucu) (Revision 1376753)

            Result = SUCCESS
            tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376753
            Files :

            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
            Show
            hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2696 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2696/ ) HADOOP-4572 . Can not access user logs - Jetty is not configured by default to serve aliases/symlinks (ahmed via tucu) (Revision 1376753) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376753 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
            Hide
            Permalink
            hudson Hudson added a comment -

            Integrated in Hadoop-Mapreduce-trunk-Commit #2660 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2660/)
            HADOOP-4572. Can not access user logs - Jetty is not configured by default to serve aliases/symlinks (ahmed via tucu) (Revision 1376753)

            Result = FAILURE
            tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376753
            Files :

            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
            Show
            hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2660 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2660/ ) HADOOP-4572 . Can not access user logs - Jetty is not configured by default to serve aliases/symlinks (ahmed via tucu) (Revision 1376753) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376753 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
            Hide
            Permalink
            hudson Hudson added a comment -

            Integrated in Hadoop-Hdfs-trunk #1144 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1144/)
            HADOOP-4572. Can not access user logs - Jetty is not configured by default to serve aliases/symlinks (ahmed via tucu) (Revision 1376753)

            Result = FAILURE
            tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376753
            Files :

            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
            Show
            hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1144 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1144/ ) HADOOP-4572 . Can not access user logs - Jetty is not configured by default to serve aliases/symlinks (ahmed via tucu) (Revision 1376753) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376753 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
            Hide
            Permalink
            hudson Hudson added a comment -

            Integrated in Hadoop-Mapreduce-trunk #1175 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1175/)
            HADOOP-4572. Can not access user logs - Jetty is not configured by default to serve aliases/symlinks (ahmed via tucu) (Revision 1376753)

            Result = FAILURE
            tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376753
            Files :

            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
            Show
            hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1175 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1175/ ) HADOOP-4572 . Can not access user logs - Jetty is not configured by default to serve aliases/symlinks (ahmed via tucu) (Revision 1376753) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376753 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/core-default.xml

              People

              • Assignee:
                szetszwo Tsz Wo Nicholas Sze
                Reporter:
                szetszwo Tsz Wo Nicholas Sze
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development