[HADOOP-4498] JobHistory does not escape literal jobName when used in a regex pattern

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 0.19.0
• Fix Version/s: 0.19.0
• Assignee: Chris Wensel
• Reporter: Chris Wensel
• Created: 22/Oct/08 22:40
• Updated: 08/Jul/09 16:53
• Resolved: 31/Oct/08 00:11

Description

JobHistory#getJobHistoryFileName throws a PatternSyntaxException if the jobName includes characters that could be regex metacharacters or metasequences and are subsequently considered malformed.

Trace:
Exception in thread "initJobs" java.util.regex.PatternSyntaxException: Unclosed character class near index 97
....
at java.util.regex.Pattern.error(Pattern.java:1713)
at java.util.regex.Pattern.clazz(Pattern.java:2254)
at java.util.regex.Pattern.clazz(Pattern.java:2210)
at java.util.regex.Pattern.sequence(Pattern.java:1818)
at java.util.regex.Pattern.expr(Pattern.java:1752)
at java.util.regex.Pattern.compile(Pattern.java:1460)
at java.util.regex.Pattern.<init>(Pattern.java:1133)
at java.util.regex.Pattern.compile(Pattern.java:823)
at org.apache.hadoop.mapred.JobHistory$JobInfo.getJobHistoryFileName(JobHistory.java:632)
at org.apache.hadoop.mapred.JobHistory$JobInfo.finalizeRecovery(JobHistory.java:740)
at org.apache.hadoop.mapred.JobTracker.finalizeJob(JobTracker.java:1532)
at org.apache.hadoop.mapred.JobInProgress.garbageCollect(JobInProgress.java:2232)
at org.apache.hadoop.mapred.JobInProgress.terminateJob(JobInProgress.java:1938)
at org.apache.hadoop.mapred.JobInProgress.terminate(JobInProgress.java:1953)
at org.apache.hadoop.mapred.JobInProgress.fail(JobInProgress.java:2012)
at org.apache.hadoop.mapred.EagerTaskInitializationListener$JobInitThread.run(EagerTaskInitializationListener.java:62)
at java.lang.Thread.run(Thread.java:637)

Issue Links

• relates to: MAPREDUCE-70 Unify the way job history filename is parsed