Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.19.0
    • Component/s: None
    • Labels:
      None

      Description

      add tags field
      add version number to chunkImpl (contribute by Eric Y.)

      1. HADOOP-4431.patch
        30 kB
        Jerome Boulon
      2. HADOOP-4431.patch
        15 kB
        Jerome Boulon

        Issue Links

          Activity

          Hide
          jboulon Jerome Boulon added a comment -

          Add test class for ChunkImpl

          Show
          jboulon Jerome Boulon added a comment - Add test class for ChunkImpl
          Hide
          jboulon Jerome Boulon added a comment -

          ChunkImpl versionning
          ChunkImpl tests
          Agent tags

          Show
          jboulon Jerome Boulon added a comment - ChunkImpl versionning ChunkImpl tests Agent tags
          Hide
          jboulon Jerome Boulon added a comment -

          Patch available

          Show
          jboulon Jerome Boulon added a comment - Patch available
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12392319/HADOOP-4431.patch
          against trunk revision 705762.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 17 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3488/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3488/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3488/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3488/console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12392319/HADOOP-4431.patch against trunk revision 705762. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 17 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3488/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3488/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3488/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3488/console This message is automatically generated.
          Hide
          eyang Eric Yang added a comment -

          +1 important patch for chukwa chunk protocol versioning.

          Show
          eyang Eric Yang added a comment - +1 important patch for chukwa chunk protocol versioning.
          Hide
          johanoskarsson Johan Oskarsson added a comment -

          The patch looks good but I'm going to be picky, there are a few places in the patch where the code style is a bit off. It's using tabs instead of two spaces for indentation and { in the wrong places etc. Please see: http://wiki.apache.org/hadoop/HowToContribute for more information.

          Other then that it looks good. Could you please regenerate it and I'll commit it. Is the patch to marked as an incompatible change?

          Show
          johanoskarsson Johan Oskarsson added a comment - The patch looks good but I'm going to be picky, there are a few places in the patch where the code style is a bit off. It's using tabs instead of two spaces for indentation and { in the wrong places etc. Please see: http://wiki.apache.org/hadoop/HowToContribute for more information. Other then that it looks good. Could you please regenerate it and I'll commit it. Is the patch to marked as an incompatible change?
          Hide
          jboulon Jerome Boulon added a comment -

          Same patch with spaces instead of tabs but since tab were already there it may be better to commit the patch with the wrong indentation and create another Jira to change tab into space.

          /Jerome.

          Show
          jboulon Jerome Boulon added a comment - Same patch with spaces instead of tabs but since tab were already there it may be better to commit the patch with the wrong indentation and create another Jira to change tab into space. /Jerome.
          Hide
          johanoskarsson Johan Oskarsson added a comment -

          I just committed this. Thanks, Jerome.
          I chose the first version of the patch as you were right, I've opened an issue about the codestyle here: HADOOP-4504

          Show
          johanoskarsson Johan Oskarsson added a comment - I just committed this. Thanks, Jerome. I chose the first version of the patch as you were right, I've opened an issue about the codestyle here: HADOOP-4504
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-trunk #640 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/640/)
          . Add versionning/tags to Chukwa Chunk.
          (Jerome Boulon via Johan)

          Show
          hudson Hudson added a comment - Integrated in Hadoop-trunk #640 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/640/ ) . Add versionning/tags to Chukwa Chunk. (Jerome Boulon via Johan)

            People

            • Assignee:
              jboulon Jerome Boulon
              Reporter:
              jboulon Jerome Boulon
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development