Details
Description
ChecksumFileSystem does not override the following method
public FSDataOutputStream create(Path f, FsPermission permission, boolean overwrite, int bufferSize, short replication, long blockSize, Progressable progress) throws IOException
As a consequence, when creating a file with LocalFileSystem and the create method above, no checksum will be created.
Issue Links
- is related to
-
HADOOP-4292
append() does not work for LocalFileSystem
-
- Closed
-
-
HADOOP-4328
Some convenient methods in the FileSystem API should be final.
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
To avoid such a mistake again, should we make rest of the create methods in FileSystem class final?
4326_20081001b.patch: updated the test.
> To avoid such a mistake again, should we make rest of the create methods in FileSystem class final?
+1 Created HADOOP-4328
4326_20081001b_0.18.patch: for 0.18
+1 patch looks good.
"ant test-patch" results:
[exec] +1 overall.
[exec] +1 @author. The patch does not contain any @author tags.
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
4326_20081001b.patch: upload the same patch again, so that hudson will pick up the correct file.
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12391341/4326_20081001b.patch
against trunk revision 700997.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3422/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3422/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3422/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3422/console
This message is automatically generated.
The failed TestLeaseRecovery2 is addressed in HADOOP-4257.
Is this an incompatible change?
This one should also be committed to 0.17
4326_20081001b_0.17.patch: for 0.17
I just committed this.
Integrated in Hadoop-trunk #623 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/623/)
. ChecksumFileSystem does not override create(...) correctly. (szetszwo)
4326_20081001.patch: fixed ChecksumFileSystem.create