Hadoop Common
  1. Hadoop Common
  2. HADOOP-4326

ChecksumFileSystem does not override all create(...) methods

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.17.3, 0.18.2
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      ChecksumFileSystem does not override the following method

      public FSDataOutputStream create(Path f, FsPermission permission,
            boolean overwrite, int bufferSize, short replication, long blockSize,
            Progressable progress) throws IOException 
      

      As a consequence, when creating a file with LocalFileSystem and the create method above, no checksum will be created.

      1. 4326_20081001b_0.17.patch
        3 kB
        Tsz Wo Nicholas Sze
      2. 4326_20081001b.patch
        3 kB
        Tsz Wo Nicholas Sze
      3. 4326_20081001b_0.18.patch
        3 kB
        Tsz Wo Nicholas Sze
      4. 4326_20081001.patch
        3 kB
        Tsz Wo Nicholas Sze

        Issue Links

          Activity

          Hide
          Tsz Wo Nicholas Sze added a comment -

          4326_20081001.patch: fixed ChecksumFileSystem.create

          Show
          Tsz Wo Nicholas Sze added a comment - 4326_20081001.patch: fixed ChecksumFileSystem.create
          Hide
          Raghu Angadi added a comment -

          To avoid such a mistake again, should we make rest of the create methods in FileSystem class final?

          Show
          Raghu Angadi added a comment - To avoid such a mistake again, should we make rest of the create methods in FileSystem class final?
          Hide
          Tsz Wo Nicholas Sze added a comment -

          4326_20081001b.patch: updated the test.

          Show
          Tsz Wo Nicholas Sze added a comment - 4326_20081001b.patch: updated the test.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          > To avoid such a mistake again, should we make rest of the create methods in FileSystem class final?

          +1 Created HADOOP-4328

          Show
          Tsz Wo Nicholas Sze added a comment - > To avoid such a mistake again, should we make rest of the create methods in FileSystem class final? +1 Created HADOOP-4328
          Hide
          Tsz Wo Nicholas Sze added a comment -

          4326_20081001b_0.18.patch: for 0.18

          Show
          Tsz Wo Nicholas Sze added a comment - 4326_20081001b_0.18.patch: for 0.18
          Hide
          Raghu Angadi added a comment -

          +1 patch looks good.

          Show
          Raghu Angadi added a comment - +1 patch looks good.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          "ant test-patch" results:

               [exec] +1 overall.  
          
               [exec]     +1 @author.  The patch does not contain any @author tags.
          
               [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
          
               [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
          
               [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
          
               [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
          
               [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
          
          Show
          Tsz Wo Nicholas Sze added a comment - "ant test-patch" results: [exec] +1 overall. [exec] +1 @author. The patch does not contain any @author tags. [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          4326_20081001b.patch: upload the same patch again, so that hudson will pick up the correct file.

          Show
          Tsz Wo Nicholas Sze added a comment - 4326_20081001b.patch: upload the same patch again, so that hudson will pick up the correct file.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12391341/4326_20081001b.patch
          against trunk revision 700997.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3422/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3422/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3422/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3422/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12391341/4326_20081001b.patch against trunk revision 700997. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3422/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3422/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3422/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3422/console This message is automatically generated.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          The failed TestLeaseRecovery2 is addressed in HADOOP-4257.

          Show
          Tsz Wo Nicholas Sze added a comment - The failed TestLeaseRecovery2 is addressed in HADOOP-4257 .
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Is this an incompatible change?

          Show
          Tsz Wo Nicholas Sze added a comment - Is this an incompatible change?
          Hide
          Tsz Wo Nicholas Sze added a comment -

          This one should also be committed to 0.17

          Show
          Tsz Wo Nicholas Sze added a comment - This one should also be committed to 0.17
          Hide
          Tsz Wo Nicholas Sze added a comment -

          4326_20081001b_0.17.patch: for 0.17

          Show
          Tsz Wo Nicholas Sze added a comment - 4326_20081001b_0.17.patch: for 0.17
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I just committed this.

          Show
          Tsz Wo Nicholas Sze added a comment - I just committed this.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-trunk #623 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/623/)
          . ChecksumFileSystem does not override create(...) correctly. (szetszwo)

          Show
          Hudson added a comment - Integrated in Hadoop-trunk #623 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/623/ ) . ChecksumFileSystem does not override create(...) correctly. (szetszwo)

            People

            • Assignee:
              Tsz Wo Nicholas Sze
              Reporter:
              Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development