[HADOOP-4228] dfs datanode metrics, bytes_read, bytes_written overflows due to incorrect type used. - ASF JIRA

Details

Type: Bug
Status: Closed
Priority: Blocker
Resolution: Fixed
Affects Version/s: 0.18.2, 0.19.0
Fix Version/s: 0.18.2
Component/s: metrics
Labels:
None
Environment:

Red Hat Enterprise Linux AS release 4 (Nahant Update 5), Java 1.6.

Hadoop Flags:

Incompatible change, Reviewed
Release Note:
Changed bytes_read, bytes_written to type long to prevent metrics overflow.

Description

bytes_read, and bytes_written metrics are using int (MetricsTimeVaryingInt) as counter. This type is too small to store the bytes_read and bytes_written metrics. Recommend to change this to long (metricsLongValue).

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending

Attachments

HADOOP-4228.patch

22/Sep/08 21:33

10 kB

Eric Yang
HADOOP-4228-trunk.patch

22/Sep/08 23:57

11 kB

Eric Yang
metricsLong.patch

02/Oct/08 21:39

6 kB

Hairong Kuang
metricsLong1.patch

06/Oct/08 17:52

6 kB

Hairong Kuang
metricsLong1-br18.patch

06/Oct/08 17:51

6 kB

Hairong Kuang

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Eric Yang added a comment - 22/Sep/08 21:31

Patch to change metrics type from Integer to Long.

Show

Eric Yang added a comment - 22/Sep/08 21:31 Patch to change metrics type from Integer to Long.

Hide

Permalink

Eric Yang added a comment - 22/Sep/08 21:33

Patch to change bytes_read and bytes_written metrics from type Integer to type long.

Show

Eric Yang added a comment - 22/Sep/08 21:33 Patch to change bytes_read and bytes_written metrics from type Integer to type long.

Hide

Permalink

Eric Yang added a comment - 22/Sep/08 23:57

Same patch for trunk.

Show

Eric Yang added a comment - 22/Sep/08 23:57 Same patch for trunk.

Hide

Permalink

Hadoop QA added a comment - 23/Sep/08 04:14

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12390702/HADOOP-4228-trunk.patch
against trunk revision 697306.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 6 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

-1 core tests. The patch failed core unit tests.

-1 contrib tests. The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3349/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3349/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3349/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3349/console

This message is automatically generated.

Show

Hadoop QA added a comment - 23/Sep/08 04:14 -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12390702/HADOOP-4228-trunk.patch against trunk revision 697306. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3349/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3349/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3349/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3349/console This message is automatically generated.

Hide

Permalink

Eric Yang added a comment - 23/Sep/08 20:57

The failed test has no relationship to this patch. There is probably something else committed to trunk which caused Balancer test failure.

Show

Eric Yang added a comment - 23/Sep/08 20:57 The failed test has no relationship to this patch. There is probably something else committed to trunk which caused Balancer test failure.

Hide

Permalink

Hairong Kuang added a comment - 01/Oct/08 00:18

The SimulatedDataNodeMetrics seems quite dummy, which is introduced for only the testing purpose.

A side note: DataNodeStatics and DataNodeStaticsMBean collect bytesRead but not bytesWritten. They should collect metrics bytesWritten as well.

Show

Hairong Kuang added a comment - 01/Oct/08 00:18 The SimulatedDataNodeMetrics seems quite dummy, which is introduced for only the testing purpose. A side note: DataNodeStatics and DataNodeStaticsMBean collect bytesRead but not bytesWritten. They should collect metrics bytesWritten as well.

Hide

Permalink

Hairong Kuang added a comment - 02/Oct/08 21:39

This patch has the following changes:
1. DataNode's metrics bytesRead & bytesWritten are changed to be long;
2. Add getBytesWritten method to DataNodesStaticsticsMBean;
3. Add a unit test to see if DataNodeMetrics can handle long number of bytes written.

Show

Hairong Kuang added a comment - 02/Oct/08 21:39 This patch has the following changes: 1. DataNode's metrics bytesRead & bytesWritten are changed to be long; 2. Add getBytesWritten method to DataNodesStaticsticsMBean; 3. Add a unit test to see if DataNodeMetrics can handle long number of bytes written.

Hide

Permalink

Sanjay Radia added a comment - 03/Oct/08 19:54

Show

Sanjay Radia added a comment - 03/Oct/08 19:54 +1

Hide

Permalink

Hadoop QA added a comment - 03/Oct/08 23:42

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12391383/metricsLong.patch
against trunk revision 701476.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 6 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

-1 core tests. The patch failed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3431/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3431/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3431/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3431/console

This message is automatically generated.

Show

Hadoop QA added a comment - 03/Oct/08 23:42 -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12391383/metricsLong.patch against trunk revision 701476. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3431/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3431/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3431/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3431/console This message is automatically generated.

Hide

Permalink

Hairong Kuang added a comment - 06/Oct/08 17:51

This is a patch for branch 18.

Show

Hairong Kuang added a comment - 06/Oct/08 17:51 This is a patch for branch 18.

Hide

Permalink

Hairong Kuang added a comment - 06/Oct/08 17:52

This is a patch for the trunk. It removes the change to DFSTestUtil that caused the failed tests.

Show

Hairong Kuang added a comment - 06/Oct/08 17:52 This is a patch for the trunk. It removes the change to DFSTestUtil that caused the failed tests.

Hide

Permalink

Brian Bockelman added a comment - 06/Oct/08 23:50

Changing the type to Long breaks Ganglia metrics reporting (there's a static mapping of Java type -> Ganglia type; there's no current Long type, meaning the map returns null and causes a NPE).

Ganglia has no Long type - perhaps a solution would be to map Longs in Ganglia to a float?

See also:
~~HADOOP-4137~~
~~HADOOP-3422~~

Show

Brian Bockelman added a comment - 06/Oct/08 23:50 Changing the type to Long breaks Ganglia metrics reporting (there's a static mapping of Java type -> Ganglia type; there's no current Long type, meaning the map returns null and causes a NPE). Ganglia has no Long type - perhaps a solution would be to map Longs in Ganglia to a float? See also: HADOOP-4137 HADOOP-3422

Hide

Permalink

Mac Yang added a comment - 08/Oct/08 00:10

> Ganglia has no Long type - perhaps a solution would be to map Longs in Ganglia to a float?

Short of supporting the Long data type, this seems like a reasonable thing to do.

Brian, would you mind coming up with the patch for the Ganglia context?

Show

Mac Yang added a comment - 08/Oct/08 00:10 > Ganglia has no Long type - perhaps a solution would be to map Longs in Ganglia to a float? Short of supporting the Long data type, this seems like a reasonable thing to do. Brian, would you mind coming up with the patch for the Ganglia context?

Hide

Permalink

Hairong Kuang added a comment - 08/Oct/08 05:40

Thank Brian for submitting a patch to ~~HADOOP-4137~~ for handling Long type in Ganglia context. I am resubmitting my patch to hudson.

Show

Hairong Kuang added a comment - 08/Oct/08 05:40 Thank Brian for submitting a patch to HADOOP-4137 for handling Long type in Ganglia context. I am resubmitting my patch to hudson.

Hide

Permalink

Eric Yang added a comment - 09/Oct/08 04:48

+1 for Hairong's patch. The patch provides real test cases.

Show

Eric Yang added a comment - 09/Oct/08 04:48 +1 for Hairong's patch. The patch provides real test cases.

Hide

Permalink

Hairong Kuang added a comment - 10/Oct/08 21:19

Resubmit the patch since the hudson patch process is back.

Show

Hairong Kuang added a comment - 10/Oct/08 21:19 Resubmit the patch since the hudson patch process is back.

Hide

Permalink

Hadoop QA added a comment - 11/Oct/08 04:22

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12391556/metricsLong1.patch
against trunk revision 703609.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3442/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3442/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3442/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3442/console

This message is automatically generated.

Show

Hadoop QA added a comment - 11/Oct/08 04:22 +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12391556/metricsLong1.patch against trunk revision 703609. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3442/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3442/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3442/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3442/console This message is automatically generated.

Hide

Permalink

Hairong Kuang added a comment - 13/Oct/08 07:23

I just committed this. Thanks Eric!

Show

Hairong Kuang added a comment - 13/Oct/08 07:23 I just committed this. Thanks Eric!

Hide

Permalink

Hudson added a comment - 13/Oct/08 18:16

Integrated in Hadoop-trunk #632 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/632/)
. The type of dfs datanoe metrics, bytes_read and bytes_written, is changed to be long. Contributed by Eric Yang and Hairong Kuang.

Show

Hudson added a comment - 13/Oct/08 18:16 Integrated in Hadoop-trunk #632 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/632/ ) . The type of dfs datanoe metrics, bytes_read and bytes_written, is changed to be long. Contributed by Eric Yang and Hairong Kuang.

People

Assignee:

Eric Yang

Reporter:

Eric Yang

Votes:

0 Vote for this issue

Watchers:

1 Start watching this issue

Dates

Created:

19/Sep/08 23:45

Updated:

04/Nov/08 18:48

Resolved:

13/Oct/08 07:23

Development

Agile

View on Board