Hadoop Common
  1. Hadoop Common
  2. HADOOP-4137

NPE in GangliaContext.xdr_string (GangliaContext.java:195)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Duplicate
    • Affects Version/s: 0.18.0, 0.18.1
    • Fix Version/s: None
    • Component/s: metrics
    • Labels:
      None

      Description

      Exception in thread "Timer thread for monitoring dfs" java.lang.NullPointerException
      at org.apache.hadoop.metrics.ganglia.GangliaContext.xdr_string(GangliaContext.java:195)
      at org.apache.hadoop.metrics.ganglia.GangliaContext.emitMetric(GangliaContext.java:138)
      at org.apache.hadoop.metrics.ganglia.GangliaContext.emitRecord(GangliaContext.java:123)
      at org.apache.hadoop.metrics.spi.AbstractMetricsContext.emitRecords(AbstractMetricsContext.java:304)
      at org.apache.hadoop.metrics.spi.AbstractMetricsContext.timerEvent(AbstractMetricsContext.java:290)
      at org.apache.hadoop.metrics.spi.AbstractMetricsContext.access$000(AbstractMetricsContext.java:50)
      at org.apache.hadoop.metrics.spi.AbstractMetricsContext$1.run(AbstractMetricsContext.java:249)
      at java.util.TimerThread.mainLoop(Unknown Source)
      at java.util.TimerThread.run(Unknown Source)

      It looks like this caused the datanode to hang, though I accidentally killed the datanode before I could dump its stack.

      1. hadoop_ganglia_npe-4137.patch
        1 kB
        Brian Bockelman
      2. hadoop_ganglia_npe-4137.patch
        1 kB
        Brian Bockelman

        Issue Links

          Activity

          Hide
          Brian Bockelman added a comment -

          Catch the NPE reported on bug HADOOP-4137; also fixes another NPE which was immediately triggered in 0.18.1 after applying the patch.

          With this patch and the patch for HADOOP-3422, Ganglia metrics are working again.

          Show
          Brian Bockelman added a comment - Catch the NPE reported on bug HADOOP-4137 ; also fixes another NPE which was immediately triggered in 0.18.1 after applying the patch. With this patch and the patch for HADOOP-3422 , Ganglia metrics are working again.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12391474/hadoop_ganglia_npe-4137.patch
          against trunk revision 701476.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no tests are needed for this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3432/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3432/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3432/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3432/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12391474/hadoop_ganglia_npe-4137.patch against trunk revision 701476. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3432/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3432/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3432/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3432/console This message is automatically generated.
          Hide
          Brian Bockelman added a comment -

          Updated patch: Silly me, Ganglia has no long data type - and I mapped it to int32, which overflows quickly (especially when reporting bytes transferred!).

          This now maps Long to float in Ganglia.

          Show
          Brian Bockelman added a comment - Updated patch: Silly me, Ganglia has no long data type - and I mapped it to int32, which overflows quickly (especially when reporting bytes transferred!). This now maps Long to float in Ganglia.
          Hide
          Brian Bockelman added a comment -

          Please close this issue; it is fixed by the patch for HADOOP-3422.

          Show
          Brian Bockelman added a comment - Please close this issue; it is fixed by the patch for HADOOP-3422 .

            People

            • Assignee:
              Unassigned
              Reporter:
              Michael Bieniosek
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development