Hadoop Common
  1. Hadoop Common
  2. HADOOP-4133

remove derby.log files form repository and also change the location where these files get created

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.19.0
    • Fix Version/s: 0.19.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      running unit tests generate derby.log files in the current working directory. these files were mistakenly checked into the repository as well. this jira is to move them from repo and change the location of the derby.log file.

      1. hadoop-4133-1.patch
        9 kB
        Prasad Chakka
      2. hadoop-4133-2.patch
        7 kB
        Prasad Chakka

        Activity

        Hide
        Ashish Thusoo added a comment -

        Should the new property go into the test conf instead. Otherwise anytime we add new tests we have to do the dance of setting it up for the test .

        Show
        Ashish Thusoo added a comment - Should the new property go into the test conf instead. Otherwise anytime we add new tests we have to do the dance of setting it up for the test .
        Hide
        Prasad Chakka added a comment -

        I thought about but Hive does't set the config properties into System properties which is where derby looks at. Unless we take all config properties and add them to be System properties, this can't be done automatically. Or is there a way?

        Show
        Prasad Chakka added a comment - I thought about but Hive does't set the config properties into System properties which is where derby looks at. Unless we take all config properties and add them to be System properties, this can't be done automatically. Or is there a way?
        Hide
        Ashish Thusoo added a comment -

        Is it not possible to set sysproperty in the junit target in build-common.xml?

        Show
        Ashish Thusoo added a comment - Is it not possible to set sysproperty in the junit target in build-common.xml?
        Hide
        Prasad Chakka added a comment -

        i think by adding this property into build-common.xml's junit target, this would work.

        Show
        Prasad Chakka added a comment - i think by adding this property into build-common.xml's junit target, this would work.
        Hide
        Prasad Chakka added a comment -

        here is the patch with build-common.xml fix

        Show
        Prasad Chakka added a comment - here is the patch with build-common.xml fix
        Hide
        Ashish Thusoo added a comment -

        +1

        Looks fine to me.

        Show
        Ashish Thusoo added a comment - +1 Looks fine to me.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12389785/hadoop-4133-2.patch
        against trunk revision 693587.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3225/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3225/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3225/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3225/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12389785/hadoop-4133-2.patch against trunk revision 693587. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3225/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3225/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3225/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3225/console This message is automatically generated.
        Hide
        dhruba borthakur added a comment -

        I just committed this. Thanks Prasad!

        Show
        dhruba borthakur added a comment - I just committed this. Thanks Prasad!

          People

          • Assignee:
            Prasad Chakka
            Reporter:
            Prasad Chakka
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development