Hadoop Common
  1. Hadoop Common
  2. HADOOP-3741

SecondaryNameNode has http server on dfs.secondary.http.address but without any contents

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.19.0
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Backup namenode's web UI default page now has some useful content.

      Description

      SecondaryNameNode has http server on dfs.secondary.http.address but does not have any information on it. It could publish useful information about NameNode it is talking to, checkpoints, the current configured checkpoint interval and checkpoint size and also configured directories.

      1. SecondaryNameNode web ui.jpg
        98 kB
        Tsz Wo Nicholas Sze
      2. 3741_20090206.patch
        7 kB
        Tsz Wo Nicholas Sze
      3. 3741_20090206b.patch
        6 kB
        Tsz Wo Nicholas Sze

        Issue Links

          Activity

          Hide
          Robert Chansler added a comment -

          Editorial pass over all release notes prior to publication of 0.21.

          Show
          Robert Chansler added a comment - Editorial pass over all release notes prior to publication of 0.21.
          Hide
          Hudson added a comment -
          Show
          Hudson added a comment - Integrated in Hadoop-trunk #756 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/756/ )
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I committed this.

          Show
          Tsz Wo Nicholas Sze added a comment - I committed this.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          >> release audit: License header is not added to html and jsp files. It is consistent with our approach.
          >
          > I don't think there is any reason why we couldn't add licence headers to html and jsp files. I notice that package.hmtl files have them, as do Chukwa's jsps.

          I agree that we should include license in html and jsp files but I am not sure why we did not do that in the past. I will raise this question in the hadoop-dev mailing list.

          For this issue, I think we could commit it first. If there is a need, I will open a new issue for adding the licenses.

          Show
          Tsz Wo Nicholas Sze added a comment - >> release audit: License header is not added to html and jsp files. It is consistent with our approach. > > I don't think there is any reason why we couldn't add licence headers to html and jsp files. I notice that package.hmtl files have them, as do Chukwa's jsps. I agree that we should include license in html and jsp files but I am not sure why we did not do that in the past. I will raise this question in the hadoop-dev mailing list. For this issue, I think we could commit it first. If there is a need, I will open a new issue for adding the licenses.
          Hide
          Tom White added a comment -

          release audit: License header is not added to html and jsp files. It is consistent with our approach.

          I don't think there is any reason why we couldn't add licence headers to html and jsp files. I notice that package.hmtl files have them, as do Chukwa's jsps.

          Show
          Tom White added a comment - release audit: License header is not added to html and jsp files. It is consistent with our approach. I don't think there is any reason why we couldn't add licence headers to html and jsp files. I notice that package.hmtl files have them, as do Chukwa's jsps.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12399702/3741_20090206b.patch
          against trunk revision 741776.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no tests are needed for this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 1 new Findbugs warnings.

          +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

          -1 release audit. The applied patch generated 823 release audit warnings (more than the trunk's current 820 warnings).

          +1 core tests. The patch passed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3811/testReport/
          Release audit warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3811/artifact/trunk/current/releaseAuditDiffWarnings.txt
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3811/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3811/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3811/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12399702/3741_20090206b.patch against trunk revision 741776. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. -1 release audit. The applied patch generated 823 release audit warnings (more than the trunk's current 820 warnings). +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3811/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3811/artifact/trunk/current/releaseAuditDiffWarnings.txt Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3811/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3811/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3811/console This message is automatically generated.
          Hide
          Tsz Wo Nicholas Sze added a comment -
               [exec] -1 overall.
               [exec]
               [exec] +1 @author. The patch does not contain any @author tags.
               [exec]
               [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
               [exec] Please justify why no tests are needed for this patch.
               [exec]
               [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
               [exec]
               [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
               [exec]
               [exec] -1 findbugs. The patch appears to introduce 1 new Findbugs warnings.
               [exec]
               [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
               [exec]
               [exec] -1 release audit. The applied patch generated 831 release audit warnings (more than the trunk's current 827 warnings).
          
          • No new tests added because we do not use unit tests to test web ui.
          • findbugs warning: "org.apache.hadoop.hdfs.server.namenode.status_jsp._jspx_resourceInjector is a mutable servlet field"
            The field is generated by the jsp compiler, not the patch.
          • release audit: License header is not added to html and jsp files. It is consistent with our approach.
          Show
          Tsz Wo Nicholas Sze added a comment - [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 1 new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. [exec] [exec] -1 release audit. The applied patch generated 831 release audit warnings (more than the trunk's current 827 warnings). No new tests added because we do not use unit tests to test web ui. findbugs warning: "org.apache.hadoop.hdfs.server.namenode.status_jsp._jspx_resourceInjector is a mutable servlet field" The field is generated by the jsp compiler, not the patch. release audit: License header is not added to html and jsp files. It is consistent with our approach.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          3741_20090206b.patch: cleanup codes.

          Show
          Tsz Wo Nicholas Sze added a comment - 3741_20090206b.patch: cleanup codes.
          Hide
          Lohit Vijayarenu added a comment -

          +1. This looks good

          Show
          Lohit Vijayarenu added a comment - +1. This looks good
          Hide
          Tsz Wo Nicholas Sze added a comment -

          3741_20090206.patch: add SecondaryNameNode web ui

          Show
          Tsz Wo Nicholas Sze added a comment - 3741_20090206.patch: add SecondaryNameNode web ui
          Hide
          Tsz Wo Nicholas Sze added a comment -

          The http server is only used for image transfer. It is good to add new web pages for showing its information.

          Show
          Tsz Wo Nicholas Sze added a comment - The http server is only used for image transfer. It is good to add new web pages for showing its information.

            People

            • Assignee:
              Tsz Wo Nicholas Sze
              Reporter:
              Lohit Vijayarenu
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development