Hadoop Common
  1. Hadoop Common
  2. HADOOP-3679

calls to junit Assert::assertEquals invert arguments, causing misleading error messages, other minor improvements.

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      JUnit Assert::assertEquals takes its expected and actual arguments in a particular order, but many unit tests invert them. The error message from a failed assertion can be misleading.

      1. HADOOP-3679.5.patch
        27 kB
        jay vyas
      2. HADOOP-3679.4.patch
        47 kB
        jay vyas
      3. HADOOP-3679.3.patch
        21 kB
        jay vyas
      4. HADOOP-3679.patch
        21 kB
        jay vyas
      5. HADOOP-3679.2.patch
        22 kB
        jay vyas

        Activity

        Allen Wittenauer made changes -
        Fix Version/s 3.0.0 [ 12320357 ]
        Karthik Kambatla (Inactive) made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Chris Douglas made changes -
        Fix Version/s 2.5.0 [ 12326263 ]
        Fix Version/s 2.4.0 [ 12326144 ]
        Chris Douglas made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Assignee jay vyas [ jayunit100 ]
        Fix Version/s 3.0.0 [ 12320357 ]
        Fix Version/s 2.4.0 [ 12326144 ]
        Resolution Fixed [ 1 ]
        jay vyas made changes -
        Attachment HADOOP-3679.5.patch [ 12633558 ]
        jay vyas made changes -
        Attachment HADOOP-3679.4.patch [ 12633481 ]
        jay vyas made changes -
        Attachment HADOOP-3679.3.patch [ 12633292 ]
        jay vyas made changes -
        Attachment HADOOP-3679.patch [ 12633263 ]
        jay vyas made changes -
        Attachment HADOOP-3679.patch [ 12632845 ]
        jay vyas made changes -
        Attachment HADOOP-3679.2.patch [ 12632895 ]
        Chris Douglas made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        jay vyas made changes -
        Attachment HADOOP-3679.patch [ 12632845 ]
        jay vyas made changes -
        Field Original Value New Value
        Summary calls to junit Assert::assertEquals invert arguments, causing misleading error messages calls to junit Assert::assertEquals invert arguments, causing misleading error messages, other minor improvements.
        Chris Douglas created issue -

          People

          • Assignee:
            jay vyas
            Reporter:
            Chris Douglas
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development