Hadoop Common
  1. Hadoop Common
  2. HADOOP-3679

calls to junit Assert::assertEquals invert arguments, causing misleading error messages, other minor improvements.

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      JUnit Assert::assertEquals takes its expected and actual arguments in a particular order, but many unit tests invert them. The error message from a failed assertion can be misleading.

      1. HADOOP-3679.patch
        21 kB
        jay vyas
      2. HADOOP-3679.5.patch
        27 kB
        jay vyas
      3. HADOOP-3679.4.patch
        47 kB
        jay vyas
      4. HADOOP-3679.3.patch
        21 kB
        jay vyas
      5. HADOOP-3679.2.patch
        22 kB
        jay vyas

        Activity

        Hide
        jay vyas added a comment -

        Okay, I've done an initial look at this and found

        TestDataByteBuffers
        TestStat 
        TestIOUtils 
        TestRPC 
        nfs3/TestFileHandle.java
        util/TestGenericsUtil.java
        TestNetworkTopologyWithNodeGroup.java
        TestText.java
        TestTFileComparator2 
        TestPath.java
        TestIdUserGroup.java
        TestXDR.java
        
        Show
        jay vyas added a comment - Okay, I've done an initial look at this and found TestDataByteBuffers TestStat TestIOUtils TestRPC nfs3/TestFileHandle.java util/TestGenericsUtil.java TestNetworkTopologyWithNodeGroup.java TestText.java TestTFileComparator2 TestPath.java TestIdUserGroup.java TestXDR.java
        Hide
        jay vyas added a comment -

        Shall i start a patch on this ? ^^ It will include reversing assertEquals args for those classes. I cant gaurantee that it covers all 1500+ unit tests in the hadoop-common-project, but it probably gets a large chunk of these errors. Then maybe the others we can interate on a case by case basis.

        Show
        jay vyas added a comment - Shall i start a patch on this ? ^^ It will include reversing assertEquals args for those classes. I cant gaurantee that it covers all 1500+ unit tests in the hadoop-common-project, but it probably gets a large chunk of these errors. Then maybe the others we can interate on a case by case basis.
        Hide
        Chris Douglas added a comment -

        Sure; the description is overly broad/ambitious for the current codebase, so feel free to adjust it to match the fix.

        Show
        Chris Douglas added a comment - Sure; the description is overly broad/ambitious for the current codebase, so feel free to adjust it to match the fix.
        Hide
        jay vyas added a comment -

        Here's a first go at a patch. This should improve the situation for all the instances which I was able to find in a first pass using an automated method followed by manual inspection of the offending classes listed above. Let me know if any others I've missed.

        Show
        jay vyas added a comment - Here's a first go at a patch. This should improve the situation for all the instances which I was able to find in a first pass using an automated method followed by manual inspection of the offending classes listed above. Let me know if any others I've missed.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12632845/HADOOP-3679.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 12 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs:

        org.apache.hadoop.io.file.tfile.TestTFileComparator2

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3629//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3629//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12632845/HADOOP-3679.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 12 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs: org.apache.hadoop.io.file.tfile.TestTFileComparator2 +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3629//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3629//console This message is automatically generated.
        Hide
        jay vyas added a comment -

        looks like i broke TestTFileComparator2. will look now.

        Show
        jay vyas added a comment - looks like i broke TestTFileComparator2. will look now.
        Hide
        jay vyas added a comment -

        Second version of the same patch. Accidentally had moved a line out of a for loop in the last one.

        Show
        jay vyas added a comment - Second version of the same patch. Accidentally had moved a line out of a for loop in the last one.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12632895/HADOOP-3679.2.patch
        against trunk revision .

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3630//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12632895/HADOOP-3679.2.patch against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3630//console This message is automatically generated.
        Hide
        jay vyas added a comment -

        Looks like the patch didnt apply? I dont think this failure on my end but ill look into it some more.

        
        ======================================================================
        ======================================================================
            Testing patch for HADOOP-3679.
        ======================================================================
        ======================================================================
        
        
        At revision 1574638.
        HADOOP-3679 patch is being downloaded at Wed Mar  5 19:48:04 UTC 2014 from
        http://issues.apache.org/jira/secure/attachment/12632895/HADOOP-3679.2.patch
        cp: cannot stat `/home/jenkins/buildSupport/lib/*': No such file or directory
        The patch does not appear to apply with p0 to p2
        PATCH APPLICATION FAILED
        
        
        Show
        jay vyas added a comment - Looks like the patch didnt apply? I dont think this failure on my end but ill look into it some more. ====================================================================== ====================================================================== Testing patch for HADOOP-3679. ====================================================================== ====================================================================== At revision 1574638. HADOOP-3679 patch is being downloaded at Wed Mar 5 19:48:04 UTC 2014 from http://issues.apache.org/jira/secure/attachment/12632895/HADOOP-3679.2.patch cp: cannot stat `/home/jenkins/buildSupport/lib/*': No such file or directory The patch does not appear to apply with p0 to p2 PATCH APPLICATION FAILED
        Hide
        Chris Douglas added a comment -

        Did you forget --no-prefix ?

        You can leave the old versions attached, to avoid orphaning discussion about them.

        Show
        Chris Douglas added a comment - Did you forget --no-prefix ? You can leave the old versions attached, to avoid orphaning discussion about them.
        Hide
        jay vyas added a comment -

        Okay, i just attached a new one. we will see what the hadoop bot has to say.

        Show
        jay vyas added a comment - Okay, i just attached a new one. we will see what the hadoop bot has to say.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12633263/HADOOP-3679.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 12 new or modified test files.

        -1 javac. The patch appears to cause the build to fail.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3640//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12633263/HADOOP-3679.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 12 new or modified test files. -1 javac . The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3640//console This message is automatically generated.
        Hide
        Chris Douglas added a comment -

        Looks like an unresolved conflict

        +<<<<<<< Updated upstream
           
           @Test
           public void testUserUpdateSetting() throws IOException {
        @@ -82,3 +83,6 @@ public void testUserUpdateSetting() throws IOException {
             assertEquals(iug.getTimeout(), IdUserGroup.TIMEOUT_DEFAULT * 2);
           }
         }
        +=======
        +}
        +>>>>>>> Stashed changes
        
        Show
        Chris Douglas added a comment - Looks like an unresolved conflict +<<<<<<< Updated upstream @Test public void testUserUpdateSetting() throws IOException { @@ -82,3 +83,6 @@ public void testUserUpdateSetting() throws IOException { assertEquals(iug.getTimeout(), IdUserGroup.TIMEOUT_DEFAULT * 2); } } +======= +} +>>>>>>> Stashed changes
        Hide
        jay vyas added a comment -

        ah interesting sorry didnt catch that. didnt realize the merge pulled in conflicts before i patched. thanks !

        Show
        jay vyas added a comment - ah interesting sorry didnt catch that. didnt realize the merge pulled in conflicts before i patched. thanks !
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12633292/HADOOP-3679.3.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 12 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3641//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3641//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12633292/HADOOP-3679.3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 12 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3641//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3641//console This message is automatically generated.
        Hide
        jay vyas added a comment -

        yay it passed!
        Thanks for the feedback Chris Douglas .
        Anyone available for a manual review of the patch? It fixes all of the assertion orderings that i was able to find in the above classes, which were pulled out via grepping.

        Show
        jay vyas added a comment - yay it passed! Thanks for the feedback Chris Douglas . Anyone available for a manual review of the patch? It fixes all of the assertion orderings that i was able to find in the above classes, which were pulled out via grepping.
        Hide
        Akira AJISAKA added a comment -

        Thanks for taking this issue! The fix of the assertion orderings looks mostly good.
        Three comments:

        +  public static long ID_EXPECTED=Long.MAX_VALUE;
        +
           @Test
           public void testConstructor() {
        -    FileHandle handle = new FileHandle(1024);
        +    FileHandle handle = new FileHandle(ID_EXPECTED);
        

        1. This changes the test itself. Would you please separate changing the parameter from the patch?

        +    assertEquals(check.length, 
        +            dob.getLength());
        

        2. The lines like the above can be converted to one line.
        3. Conversely, this patch adds the lines over 80 characters, so please render the lines within 80 chars.

        Show
        Akira AJISAKA added a comment - Thanks for taking this issue! The fix of the assertion orderings looks mostly good. Three comments: + public static long ID_EXPECTED= Long .MAX_VALUE; + @Test public void testConstructor() { - FileHandle handle = new FileHandle(1024); + FileHandle handle = new FileHandle(ID_EXPECTED); 1. This changes the test itself. Would you please separate changing the parameter from the patch? + assertEquals(check.length, + dob.getLength()); 2. The lines like the above can be converted to one line. 3. Conversely, this patch adds the lines over 80 characters, so please render the lines within 80 chars.
        Hide
        jay vyas added a comment -

        Thanks for the review !

        Sure ill fix this up.

        Show
        jay vyas added a comment - Thanks for the review ! Sure ill fix this up.
        Hide
        Akira AJISAKA added a comment -

        Would you please keep the original code style to clean up the patch?

        -    // Test Path(String) 
        +    // Test Path(String)
        

        False whilespace changes

             // URI#toString returns an encoded path
        -    assertEquals("/foo%20bar", new URI(null, null, "/foo bar", null, null).toString());
        +    assertEquals("/foo%20bar", 
        +            new URI(null, null, "/foo bar", null, null).toString());
        

        False newlines if there are no change in codes. If you want to render existing code, please file a separate jira and create a patch.

        +    assertArrayEquals(check,
        +            Arrays.copyOf(dob.getData(), dob.getLength()));
        

        You can also convert other lines like above into one line.

        Show
        Akira AJISAKA added a comment - Would you please keep the original code style to clean up the patch? - // Test Path( String ) + // Test Path( String ) False whilespace changes // URI#toString returns an encoded path - assertEquals( "/foo%20bar" , new URI( null , null , "/foo bar" , null , null ).toString()); + assertEquals( "/foo%20bar" , + new URI( null , null , "/foo bar" , null , null ).toString()); False newlines if there are no change in codes. If you want to render existing code, please file a separate jira and create a patch. + assertArrayEquals(check, + Arrays.copyOf(dob.getData(), dob.getLength())); You can also convert other lines like above into one line.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12633481/HADOOP-3679.4.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 12 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3644//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3644//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12633481/HADOOP-3679.4.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 12 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3644//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3644//console This message is automatically generated.
        Hide
        jay vyas added a comment -

        Hi Akira/Chris and thanks for the reviews.
        Okay ive just update with those changes, and patched some other whitespace errors that i found in my original patch.
        thanks for the feedback!

        Show
        jay vyas added a comment - Hi Akira/Chris and thanks for the reviews. Okay ive just update with those changes, and patched some other whitespace errors that i found in my original patch. thanks for the feedback!
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12633558/HADOOP-3679.5.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 11 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        -1 release audit. The applied patch generated 1 release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3649//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/3649//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3649//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12633558/HADOOP-3679.5.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 11 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit . The applied patch generated 1 release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3649//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/3649//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3649//console This message is automatically generated.
        Hide
        jay vyas added a comment -

        Hmmm never saw this release audit warning before. Any thoughts on why?
        It looks related to getImageServlet.

        Show
        jay vyas added a comment - Hmmm never saw this release audit warning before. Any thoughts on why? It looks related to getImageServlet.
        Hide
        Akira AJISAKA added a comment -

        This warning is not related to the patch.
        This is why another commit made 'GetImageServlet.java' empty and the file didn't have no Apache license header. Now it's fixed in the latest trunk.

        Show
        Akira AJISAKA added a comment - This warning is not related to the patch. This is why another commit made 'GetImageServlet.java' empty and the file didn't have no Apache license header. Now it's fixed in the latest trunk.
        Hide
        jay vyas added a comment -

        Great! Well i guess my job ends here . Let me know if we need any other minor updates to the patch.

        Show
        jay vyas added a comment - Great! Well i guess my job ends here . Let me know if we need any other minor updates to the patch.
        Hide
        jay vyas added a comment -

        Hi Akira AJISAKA and Chris Douglas , i guess this patch is now completed. shall we push it through ? Or any other thoughts on it.

        Show
        jay vyas added a comment - Hi Akira AJISAKA and Chris Douglas , i guess this patch is now completed. shall we push it through ? Or any other thoughts on it.
        Hide
        Chris Douglas added a comment -

        +1 I committed this. Thanks Jay

        There were still a fair number of whitespace and formatting changes, but they're mostly on blank lines so I went ahead and pushed it. In future patches, minimizing these preserves history and reduces noise for reviewers.

        Show
        Chris Douglas added a comment - +1 I committed this. Thanks Jay There were still a fair number of whitespace and formatting changes, but they're mostly on blank lines so I went ahead and pushed it. In future patches, minimizing these preserves history and reduces noise for reviewers.
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #5325 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5325/)
        HADOOP-3679. Fixup assert ordering in unit tests to yield meaningful error
        messages. Contributed by Jay Vyas (cdouglas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1577396)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestPath.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestStat.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestDataByteBuffers.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestNetworkTopologyWithNodeGroup.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestGenericsUtil.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/test/java/org/apache/hadoop/nfs/nfs3/TestFileHandle.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/test/java/org/apache/hadoop/nfs/nfs3/TestIdUserGroup.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/test/java/org/apache/hadoop/oncrpc/TestXDR.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #5325 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5325/ ) HADOOP-3679 . Fixup assert ordering in unit tests to yield meaningful error messages. Contributed by Jay Vyas (cdouglas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1577396 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestPath.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestStat.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestDataByteBuffers.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestNetworkTopologyWithNodeGroup.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestGenericsUtil.java /hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/test/java/org/apache/hadoop/nfs/nfs3/TestFileHandle.java /hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/test/java/org/apache/hadoop/nfs/nfs3/TestIdUserGroup.java /hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/test/java/org/apache/hadoop/oncrpc/TestXDR.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #509 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/509/)
        HADOOP-3679. Fixup assert ordering in unit tests to yield meaningful error
        messages. Contributed by Jay Vyas (cdouglas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1577396)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestPath.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestStat.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestDataByteBuffers.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestNetworkTopologyWithNodeGroup.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestGenericsUtil.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/test/java/org/apache/hadoop/nfs/nfs3/TestFileHandle.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/test/java/org/apache/hadoop/nfs/nfs3/TestIdUserGroup.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/test/java/org/apache/hadoop/oncrpc/TestXDR.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #509 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/509/ ) HADOOP-3679 . Fixup assert ordering in unit tests to yield meaningful error messages. Contributed by Jay Vyas (cdouglas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1577396 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestPath.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestStat.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestDataByteBuffers.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestNetworkTopologyWithNodeGroup.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestGenericsUtil.java /hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/test/java/org/apache/hadoop/nfs/nfs3/TestFileHandle.java /hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/test/java/org/apache/hadoop/nfs/nfs3/TestIdUserGroup.java /hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/test/java/org/apache/hadoop/oncrpc/TestXDR.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #1701 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1701/)
        HADOOP-3679. Fixup assert ordering in unit tests to yield meaningful error
        messages. Contributed by Jay Vyas (cdouglas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1577396)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestPath.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestStat.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestDataByteBuffers.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestNetworkTopologyWithNodeGroup.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestGenericsUtil.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/test/java/org/apache/hadoop/nfs/nfs3/TestFileHandle.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/test/java/org/apache/hadoop/nfs/nfs3/TestIdUserGroup.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/test/java/org/apache/hadoop/oncrpc/TestXDR.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1701 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1701/ ) HADOOP-3679 . Fixup assert ordering in unit tests to yield meaningful error messages. Contributed by Jay Vyas (cdouglas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1577396 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestPath.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestStat.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestDataByteBuffers.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestNetworkTopologyWithNodeGroup.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestGenericsUtil.java /hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/test/java/org/apache/hadoop/nfs/nfs3/TestFileHandle.java /hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/test/java/org/apache/hadoop/nfs/nfs3/TestIdUserGroup.java /hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/test/java/org/apache/hadoop/oncrpc/TestXDR.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1726 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1726/)
        HADOOP-3679. Fixup assert ordering in unit tests to yield meaningful error
        messages. Contributed by Jay Vyas (cdouglas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1577396)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestPath.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestStat.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestDataByteBuffers.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestNetworkTopologyWithNodeGroup.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestGenericsUtil.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/test/java/org/apache/hadoop/nfs/nfs3/TestFileHandle.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/test/java/org/apache/hadoop/nfs/nfs3/TestIdUserGroup.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/test/java/org/apache/hadoop/oncrpc/TestXDR.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1726 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1726/ ) HADOOP-3679 . Fixup assert ordering in unit tests to yield meaningful error messages. Contributed by Jay Vyas (cdouglas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1577396 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestPath.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestStat.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestDataByteBuffers.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestNetworkTopologyWithNodeGroup.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestGenericsUtil.java /hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/test/java/org/apache/hadoop/nfs/nfs3/TestFileHandle.java /hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/test/java/org/apache/hadoop/nfs/nfs3/TestIdUserGroup.java /hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/test/java/org/apache/hadoop/oncrpc/TestXDR.java
        Hide
        jay vyas added a comment -

        thanks for helping me get my first patch in Chris Douglas Akira AJISAKA !

        Show
        jay vyas added a comment - thanks for helping me get my first patch in Chris Douglas Akira AJISAKA !

          People

          • Assignee:
            jay vyas
            Reporter:
            Chris Douglas
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development