Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-3653

test-patch target not working on hudson.zones.apache.org due to HADOOP-3480

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.18.0
    • Fix Version/s: 0.18.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HADOOP-3480 has broken the test-patch target run by the Hudson Hadoop-Patch job. This is causing all patches to get a -1 on contrib testing.

      Also, the message is very confusing now. This is what the console shows:

      ...
      [exec] [junit] 08/06/26 14:34:57 INFO ipc.Server: IPC Server handler 9 on 44137: exiting
      [exec]
      [exec] BUILD SUCCESSFUL
      [exec] Total time: 4 minutes 2 seconds
      [exec] Some jars are not declared in the Eclipse project.
      [exec]
      ...
      [exec]
      [exec] -1 contrib tests. The patch failed contrib unit tests.
      [exec]
      ...

      The -1 comes from the "Some jars are not declared in the Eclipse project" line which is a warning caused by HADOOP-3480. This needs to be improved.

      The problem arises from the fact that additional jar files are copied into the lib/ directory for clover (code coverage), checkstyle, etc by the test-patch process on Hudson. Also, there are src/test/lib/ftp*.jar referenced in the ECLIPSE_DECLARED_JARS variable:

      echo $PRESENT_JARS
      lib/clover.jar lib/commons-cli-2.0-SNAPSHOT.jar lib/commons-codec-1.3.jar lib/commons-httpclient-3.0.1.jar lib/commons-logging-1.0.4.jar lib/commons-logging-api-1.0.4.jar lib/commons-net-1.4.1.jar lib/excluded/checkstyle-all-4.3.jar lib/jets3t-0.6.0.jar lib/jetty-5.1.4.jar lib/jetty-ext/commons-el.jar lib/jetty-ext/jasper-compiler.jar lib/jetty-ext/jasper-runtime.jar lib/jetty-ext/jsp-api.jar lib/junit-3.8.1.jar lib/kfs-0.1.3.jar lib/log4j-1.2.13.jar lib/oro-2.0.8.jar lib/rat-0.5.1.jar lib/servlet-api.jar lib/slf4j-api-1.4.3.jar lib/slf4j-log4j12-1.4.3.jar lib/xmlenc-0.52.jar

      echo $ECLIPSE_DECLARED_JARS
      lib/commons-cli-2.0-SNAPSHOT.jar lib/commons-codec-1.3.jar lib/commons-httpclient-3.0.1.jar lib/commons-logging-1.0.4.jar lib/commons-logging-api-1.0.4.jar lib/commons-net-1.4.1.jar lib/jets3t-0.6.0.jar lib/jetty-5.1.4.jar lib/jetty-ext/commons-el.jar lib/jetty-ext/jasper-compiler.jar lib/jetty-ext/jasper-runtime.jar lib/jetty-ext/jsp-api.jar lib/junit-3.8.1.jar lib/kfs-0.1.3.jar lib/log4j-1.2.13.jar lib/oro-2.0.8.jar lib/servlet-api.jar lib/slf4j-api-1.4.3.jar lib/slf4j-log4j12-1.4.3.jar lib/xmlenc-0.52.jar src/test/lib/ftplet-api-1.0.0-SNAPSHOT.jar src/test/lib/ftpserver-core-1.0.0-SNAPSHOT.jar src/test/lib/ftpserver-server-1.0.0-SNAPSHOT.jar src/test/lib/mina-core-2.0.0-M2-20080407.124109-12.jar

      Brice, can you rework this?

        Attachments

        1. fixHusondBreak3480.patch
          1 kB
          Brice Arnould
        2. fixHusondBreak3480_v2.patch
          1 kB
          Brice Arnould
        3. fixHusondBreak3480_v3.patch
          1 kB
          Brice Arnould
        4. HADOOP-3653.patch
          1 kB
          Nigel Daley

          Activity

            People

            • Assignee:
              un_brice Brice Arnould
              Reporter:
              nidaley Nigel Daley
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: