[HADOOP-3592] org.apache.hadoop.fs.FileUtil.copy() will leak input streams if the destination can't be opened

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.19.0
• Fix Version/s: 0.19.0
• Component/s: fs
• Hadoop Flags: Reviewed
• Assignee: Bill de hOra
• Reporter: Steve Loughran
• Created: 18/Jun/08 16:04
• Updated: 29/Apr/10 08:09
• Resolved: 19/Sep/08 22:51

Description

FileUtil.copy() relies on IOUtils.copyBytes() to close the incoming streams, which it does. Normally.

But if dstFS.create() raises any kind of IOException, then the inputstream "in", which was created in the line above, will never get closed, and hence be leaked.

InputStream in = srcFS.open(src);
OutputStream out = dstFS.create(dst, overwrite);
IOUtils.copyBytes(in, out, conf, true);

Some try/catch wrapper around the open operations could close the streams if any exception gets thrown at that point in the copy process.

Issue Links

• is related to: HADOOP-3809 TestCLI fails on trunk point out that moveFromLocal/put output has changed