[HADOOP-3554] LineRecordReader needs more synchronization

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 0.17.0

Environment

All java platforms

• Tags: surelogic
• Assignee: Unassigned
• Reporter: Aaron Greenhouse
• Created: 13/Jun/08 14:42
• Updated: 11/Aug/11 18:41
• Resolved: 11/Aug/11 18:41

Description

LineRecordReader has three index fields start, end, and pos. All of these fields are long, which means that, in general, access to them is not atomic. This can cause problems if the fields are accessed without appropriate synchronization.

I propose the following changes to the class:

• Make the fields start and end final. This requires some minor changes to the constructor LineRecordReader(Configuration, FileSplit).
• Make the method getProgress() synchronized.