Hadoop Common
  1. Hadoop Common
  2. HADOOP-3450

Add tests to Local Directory Allocator for asserting their URI-returning capability

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.17.0
    • Fix Version/s: 2.0.2-alpha
    • Component/s: fs
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      Original comment:

      Local directory allocator returns a bare path, without a URI specifier. This means that calling Path.getFileSystem will do the wrong thing with the returned path. Should really stick a "file://" in front.

      Also it's test cases need to be improved to make sure this class works fine.

      Only the latter needed to be done (see below for discussion).

      1. HADOOP-3450.txt
        3 kB
        Sho Shimauchi

        Activity

        Hide
        Sho Shimauchi added a comment -

        fix Summary

        Show
        Sho Shimauchi added a comment - fix Summary
        Hide
        Sho Shimauchi added a comment -

        I think we don't need fix this issue now.
        Path always set file:// in front of uri, so this issue won't happen.

        Show
        Sho Shimauchi added a comment - I think we don't need fix this issue now. Path always set file:// in front of uri, so this issue won't happen.
        Hide
        Sho Shimauchi added a comment -

        btw, I'd like to submit a patch to add a new testcase for LocalDirAllocator.getLocalPathToRead() because the method doesn't have testcase.
        I had to add the testcase to investigate this issue.
        Can I attach the patch in this ticket?
        Or should I file a new JIRA?

        Show
        Sho Shimauchi added a comment - btw, I'd like to submit a patch to add a new testcase for LocalDirAllocator.getLocalPathToRead() because the method doesn't have testcase. I had to add the testcase to investigate this issue. Can I attach the patch in this ticket? Or should I file a new JIRA?
        Hide
        Harsh J added a comment -

        Hi Sho,

        More good tests are definitely welcome!

        Since issue is already fixed, it is fine if you want to add a test case via this JIRA. Please do update the summary and description of the ticket and attach your patch.

        Show
        Harsh J added a comment - Hi Sho, More good tests are definitely welcome! Since issue is already fixed, it is fine if you want to add a test case via this JIRA. Please do update the summary and description of the ticket and attach your patch.
        Hide
        Sho Shimauchi added a comment -

        thanks Harsh, I edited description and attached a patch.

        Show
        Sho Shimauchi added a comment - thanks Harsh, I edited description and attached a patch.
        Hide
        Sho Shimauchi added a comment -

        harsh, would you have a time to review my patch?

        Show
        Sho Shimauchi added a comment - harsh, would you have a time to review my patch?
        Hide
        Harsh J added a comment -

        +1 committing shortly.

        Show
        Harsh J added a comment - +1 committing shortly.
        Hide
        Harsh J added a comment -

        Committed to trunk and branch-2. Thank you Sho!

        Show
        Harsh J added a comment - Committed to trunk and branch-2. Thank you Sho!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2485 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2485/)
        HADOOP-3450. Add tests to Local Directory Allocator for asserting their URI-returning capability. Contributed by Sho Shimauchi. (harsh) (Revision 1355789)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355789
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2485 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2485/ ) HADOOP-3450 . Add tests to Local Directory Allocator for asserting their URI-returning capability. Contributed by Sho Shimauchi. (harsh) (Revision 1355789) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355789 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2417 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2417/)
        HADOOP-3450. Add tests to Local Directory Allocator for asserting their URI-returning capability. Contributed by Sho Shimauchi. (harsh) (Revision 1355789)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355789
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2417 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2417/ ) HADOOP-3450 . Add tests to Local Directory Allocator for asserting their URI-returning capability. Contributed by Sho Shimauchi. (harsh) (Revision 1355789) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355789 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2434 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2434/)
        HADOOP-3450. Add tests to Local Directory Allocator for asserting their URI-returning capability. Contributed by Sho Shimauchi. (harsh) (Revision 1355789)

        Result = FAILURE
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355789
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2434 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2434/ ) HADOOP-3450 . Add tests to Local Directory Allocator for asserting their URI-returning capability. Contributed by Sho Shimauchi. (harsh) (Revision 1355789) Result = FAILURE harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355789 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1093 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1093/)
        HADOOP-3450. Add tests to Local Directory Allocator for asserting their URI-returning capability. Contributed by Sho Shimauchi. (harsh) (Revision 1355789)

        Result = FAILURE
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355789
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1093 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1093/ ) HADOOP-3450 . Add tests to Local Directory Allocator for asserting their URI-returning capability. Contributed by Sho Shimauchi. (harsh) (Revision 1355789) Result = FAILURE harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355789 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1127 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1127/)
        HADOOP-3450. Add tests to Local Directory Allocator for asserting their URI-returning capability. Contributed by Sho Shimauchi. (harsh) (Revision 1355789)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355789
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1127 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1127/ ) HADOOP-3450 . Add tests to Local Directory Allocator for asserting their URI-returning capability. Contributed by Sho Shimauchi. (harsh) (Revision 1355789) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355789 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java

          People

          • Assignee:
            Sho Shimauchi
            Reporter:
            Ari Rabkin
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development