Hadoop Common
  1. Hadoop Common
  2. HADOOP-3450

Add tests to Local Directory Allocator for asserting their URI-returning capability

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.17.0
    • Fix Version/s: 2.0.2-alpha
    • Component/s: fs
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      Original comment:

      Local directory allocator returns a bare path, without a URI specifier. This means that calling Path.getFileSystem will do the wrong thing with the returned path. Should really stick a "file://" in front.

      Also it's test cases need to be improved to make sure this class works fine.

      Only the latter needed to be done (see below for discussion).

      1. HADOOP-3450.txt
        3 kB
        Sho Shimauchi

        Activity

        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Arun C Murthy made changes -
        Fix Version/s 2.0.2-alpha [ 12322473 ]
        Fix Version/s 2.1.0-alpha [ 12321441 ]
        Harsh J made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Target Version/s 2.0.1-alpha, 3.0.0 [ 12321441, 12320357 ]
        Fix Version/s 2.0.1-alpha [ 12321441 ]
        Resolution Fixed [ 1 ]
        Harsh J made changes -
        Summary Local Directory Allocator should return URIs Add tests to Local Directory Allocator for asserting their URI-returning capability
        Hadoop Flags Reviewed [ 10343 ]
        Target Version/s 2.0.0-alpha, 3.0.0 [ 12320352, 12320357 ] 2.0.1-alpha, 3.0.0 [ 12321441, 12320357 ]
        Description Local directory allocator returns a bare path, without a URI specifier. This means that calling Path.getFileSystem will do the wrong thing with the returned path. Should really stick a "file://" in front.

        Also it's test cases need to be improved to make sure this class works fine.

        Original comment:

        {quote}Local directory allocator returns a bare path, without a URI specifier. This means that calling Path.getFileSystem will do the wrong thing with the returned path. Should really stick a "file://" in front.

        Also it's test cases need to be improved to make sure this class works fine.
        {quote}

        Only the latter needed to be done (see below for discussion).
        Robert Joseph Evans made changes -
        Target Version/s 0.23.2 [ 12319855 ] 2.0.0, 3.0.0 [ 12320352, 12320357 ]
        Arun C Murthy made changes -
        Target Version/s 0.23.1, 0.24.0 [ 12318884, 12317652 ] 0.23.2 [ 12319855 ]
        Sho Shimauchi made changes -
        Attachment HADOOP-3450.txt [ 12510703 ]
        Sho Shimauchi made changes -
        Target Version/s 0.23.1, 0.24.0 [ 12318884, 12317652 ] 0.24.0, 0.23.1 [ 12317652, 12318884 ]
        Description Local directory allocator returns a bare path, without a URI specifier. This means that calling Path.getFileSystem will do the wrong thing with the returned path. Should really stick a "file://" in front.

        Local directory allocator returns a bare path, without a URI specifier. This means that calling Path.getFileSystem will do the wrong thing with the returned path. Should really stick a "file://" in front.

        Also it's test cases need to be improved to make sure this class works fine.

        Harsh J made changes -
        Target Version/s 0.24.0, 0.23.1 [ 12317652, 12318884 ]
        Sho Shimauchi made changes -
        Summary local disk allocator should return URIs Local Directory Allocator should return URIs
        Sho Shimauchi made changes -
        Assignee Sho Shimauchi [ sho.shimauchi ]
        Harsh J made changes -
        Field Original Value New Value
        Labels newbie
        Ari Rabkin created issue -

          People

          • Assignee:
            Sho Shimauchi
            Reporter:
            Ari Rabkin
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development