Hadoop Common
  1. Hadoop Common
  2. HADOOP-3390

Remove deprecated ClientProtocol.abandonFileInProgress()

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.18.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Removed deprecated ClientProtocol.abandonFileInProgress().

      Description

      ClientProtocol.abandonFileInProgress() was deprecated in 0.17 and is not used anywhere currently.

      1. 3390_20080514.patch
        5 kB
        Tsz Wo Nicholas Sze

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        53m 51s 1 Tsz Wo Nicholas Sze 14/May/08 18:43
        Patch Available Patch Available Resolved Resolved
        4h 42m 1 Raghu Angadi 14/May/08 23:25
        Resolved Resolved Closed Closed
        99d 20h 24m 1 Nigel Daley 22/Aug/08 19:50
        Owen O'Malley made changes -
        Component/s dfs [ 12310710 ]
        Nigel Daley made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Robert Chansler made changes -
        Hadoop Flags [Reviewed, Incompatible change] [Incompatible change, Reviewed]
        Release Note Remove deprecated ClientProtocol.abandonFileInProgress() Removed deprecated ClientProtocol.abandonFileInProgress().
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #492 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/492/ )
        Raghu Angadi made changes -
        Hadoop Flags [Reviewed, Incompatible change] [Incompatible change, Reviewed]
        Resolution Fixed [ 1 ]
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hide
        Raghu Angadi added a comment -

        I just committed this. Thanks Nicholas.

        Show
        Raghu Angadi added a comment - I just committed this. Thanks Nicholas.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12382061/3390_20080514.patch
        against trunk revision 656270.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2470/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2470/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2470/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2470/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12382061/3390_20080514.patch against trunk revision 656270. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2470/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2470/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2470/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2470/console This message is automatically generated.
        Tsz Wo Nicholas Sze made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Release Note Remove deprecated ClientProtocol.abandonFileInProgress()
        Hadoop Flags [Incompatible change, Reviewed]
        Hide
        dhruba borthakur added a comment -

        There was talk earlier about having a Java like API deleteOnExit() for HDFS files. That feature could use abandonFileInProgress but is better handled entirely in the client code. We do not need an special RPC to delete it.

        +1 for this one.

        This is an incompatible change.

        Show
        dhruba borthakur added a comment - There was talk earlier about having a Java like API deleteOnExit() for HDFS files. That feature could use abandonFileInProgress but is better handled entirely in the client code. We do not need an special RPC to delete it. +1 for this one. This is an incompatible change.
        Tsz Wo Nicholas Sze made changes -
        Field Original Value New Value
        Attachment 3390_20080514.patch [ 12382061 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        3390_20080514.patch: Remove ClientProtocol.abandonFileInProgress()

        Show
        Tsz Wo Nicholas Sze added a comment - 3390_20080514.patch: Remove ClientProtocol.abandonFileInProgress()
        Tsz Wo Nicholas Sze created issue -

          People

          • Assignee:
            Tsz Wo Nicholas Sze
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development