Hadoop Common
  1. Hadoop Common
  2. HADOOP-3368

Can commons-logging.properties be pulled from hadoop-core?

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.19.0
    • Fix Version/s: 0.19.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In the root of hadoop-core.jar is a log4j.properties and a commons-logging.properties

      while this provides good standalone functionality to hadoop, it complicates anyone else trying to control the logging, and use the libraries in-process.

      In particular, there is a commons-logging.properties file that selects Log4J as the back end. This is not needed as
      -log4j is automatically picked up if it is on the classpath
      -if it is not on the classpath, asking for it is generally considered bad form
      If you look at the commons-logging configuration details:
      http://commons.apache.org/logging/guide.html#Configuration
      you will see that that such a properties file takes priority over any setting through system properties, which makes it very hard to override the settings without adding multiple commons-logging.properties files and playing with their priority settings

      If you pull the commons-logging.properties file from hadoop-core log4j will still be picked up by default, but it becomes easier for people to turn on different logging infrastructures if they want to. It should have no visible impact on the end user experience (unlike pulling log4j.properties)

        Issue Links

          Activity

          steve_l created issue -
          steve_l made changes -
          Field Original Value New Value
          Attachment hadoop-3368.patch [ 12387030 ]
          steve_l made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Affects Version/s 0.19.0 [ 12313211 ]
          Affects Version/s 0.16.3 [ 12313092 ]
          Owen O'Malley made changes -
          Assignee Steve Loughran [ steve_l ]
          Owen O'Malley made changes -
          Hadoop Flags [Reviewed]
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Owen O'Malley made changes -
          Fix Version/s 0.19.0 [ 12313211 ]
          Robert Chansler made changes -
          Component/s build [ 12311543 ]
          Nigel Daley made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Reporter Steve Loughran [ steve_l ] Steve Loughran [ stevel@apache.org ]
          Gavin made changes -
          Assignee Steve Loughran [ steve_l ] Steve Loughran [ stevel@apache.org ]
          Steve Loughran made changes -
          Link This issue relates to HADOOP-7468 [ HADOOP-7468 ]

            People

            • Assignee:
              Steve Loughran
              Reporter:
              Steve Loughran
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development