Hadoop Common
  1. Hadoop Common
  2. HADOOP-3018

Eclipse plugin fails to compile due to missing RPC.stopClient() method

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.17.0
    • Component/s: contrib/eclipse-plugin
    • Labels:
      None

      Description

      HADOOP-2870 removed the RPC.stopClient() method which is called by org.apache.hadoop.eclipse.dfs.DFSLocationsRoot.

      1. 3018-20080405a.patch
        3 kB
        Christophe Taton
      2. HADOOP-3018.patch
        2 kB
        Lohit Vijayarenu

        Activity

        Hide
        Mukund Madhugiri added a comment -

        Will there be a patch for 0.17.0?

        Show
        Mukund Madhugiri added a comment - Will there be a patch for 0.17.0?
        Hide
        Christophe Taton added a comment -

        Yes, I'll post one soon (this week-end).

        Show
        Christophe Taton added a comment - Yes, I'll post one soon (this week-end).
        Hide
        Lohit Vijayarenu added a comment -

        eclipse build also failed due to HADOOP-2563. For the problem reported in this JIRA RPC.stopClient() has been make private which gets called automatically once reference count reaches zero. I see that the thread already calls FileSystem.closeAll() which should be good.

        Show
        Lohit Vijayarenu added a comment - eclipse build also failed due to HADOOP-2563 . For the problem reported in this JIRA RPC.stopClient() has been make private which gets called automatically once reference count reaches zero. I see that the thread already calls FileSystem.closeAll() which should be good.
        Hide
        Christophe Taton added a comment -

        3018-20080405a.patch adds a couple of other small cleanups: removes a deprecated call to fs.delete, also removes a some duplicated code.

        In fact, calling FileSystem.closeAll() seems not to be powerful enough but that's all what we can do for now.
        The RPC has not been designed for such a use as the one we have in the Eclipse plug-in, and if someone enters a wrong configuration or has some networking issues (firewall, etc), the UI might appear dead or unresponsive.

        Show
        Christophe Taton added a comment - 3018-20080405a.patch adds a couple of other small cleanups: removes a deprecated call to fs.delete, also removes a some duplicated code. In fact, calling FileSystem.closeAll() seems not to be powerful enough but that's all what we can do for now. The RPC has not been designed for such a use as the one we have in the Eclipse plug-in, and if someone enters a wrong configuration or has some networking issues (firewall, etc), the UI might appear dead or unresponsive.
        Hide
        Nigel Daley added a comment -

        Running thru Hudson now. Can you commit if it's successful?

        Show
        Nigel Daley added a comment - Running thru Hudson now. Can you commit if it's successful?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12379473/3018-20080405a.patch
        against trunk revision 643282.

        @author +1. The patch does not contain any @author tags.

        tests included -1. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        javadoc +1. The javadoc tool did not generate any warning messages.

        javac +1. The applied patch does not generate any new javac compiler warnings.

        release audit +1. The applied patch does not generate any new release audit warnings.

        findbugs +1. The patch does not introduce any new Findbugs warnings.

        core tests +1. The patch passed core unit tests.

        contrib tests +1. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2178/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2178/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2178/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2178/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12379473/3018-20080405a.patch against trunk revision 643282. @author +1. The patch does not contain any @author tags. tests included -1. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. javadoc +1. The javadoc tool did not generate any warning messages. javac +1. The applied patch does not generate any new javac compiler warnings. release audit +1. The applied patch does not generate any new release audit warnings. findbugs +1. The patch does not introduce any new Findbugs warnings. core tests +1. The patch passed core unit tests. contrib tests +1. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2178/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2178/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2178/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2178/console This message is automatically generated.
        Hide
        Christophe Taton added a comment -

        There are no tests for the eclipse plug-in.
        I just committed this. Thanks!

        Show
        Christophe Taton added a comment - There are no tests for the eclipse plug-in. I just committed this. Thanks!
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-branch #5 (See http://hudson.zones.apache.org/hudson/job/Hadoop-branch/5/ )
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #454 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/454/ )

          People

          • Assignee:
            Christophe Taton
            Reporter:
            Tom White
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development