Hadoop Common
  1. Hadoop Common
  2. HADOOP-2995

StreamBaseRecordReader's getProgress returns just 0 or 1

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: 0.16.0
        • Fix Version/s: 0.17.0
        • Component/s: None
        • Labels:
          None

          Description

          StreamBaseRecordReader.getProgress uses integer math, so progress is either 0 or 1. The patch fixes this.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Owen O'Malley added a comment -

            Marking Patch Avail for QA review

            Show
            Owen O'Malley added a comment - Marking Patch Avail for QA review
            Hide
            Permalink
            Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12377581/progress_is_0_or_1.patch
            against trunk revision 619744.

            @author +1. The patch does not contain any @author tags.

            tests included -1. The patch doesn't appear to include any new or modified tests.
            Please justify why no tests are needed for this patch.

            javadoc +1. The javadoc tool did not generate any warning messages.

            javac +1. The applied patch does not generate any new javac compiler warnings.

            release audit +1. The applied patch does not generate any new release audit warnings.

            findbugs +1. The patch does not introduce any new Findbugs warnings.

            core tests -1. The patch failed core unit tests.

            contrib tests +1. The patch passed contrib unit tests.

            Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1948/testReport/
            Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1948/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
            Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1948/artifact/trunk/build/test/checkstyle-errors.html
            Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1948/console

            This message is automatically generated.

            Show
            Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12377581/progress_is_0_or_1.patch against trunk revision 619744. @author +1. The patch does not contain any @author tags. tests included -1. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. javadoc +1. The javadoc tool did not generate any warning messages. javac +1. The applied patch does not generate any new javac compiler warnings. release audit +1. The applied patch does not generate any new release audit warnings. findbugs +1. The patch does not introduce any new Findbugs warnings. core tests -1. The patch failed core unit tests. contrib tests +1. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1948/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1948/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1948/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1948/console This message is automatically generated.
            Hide
            Permalink
            Devaraj Das added a comment -

            I just committed this. Thanks, Dave!

            Show
            Devaraj Das added a comment - I just committed this. Thanks, Dave!
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-trunk #427 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/427/)

            Show
            Hudson added a comment - Integrated in Hadoop-trunk #427 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/427/ )

              People

              • Assignee:
                Dave Brosius
                Reporter:
                Dave Brosius
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development