Hadoop Common
  1. Hadoop Common
  2. HADOOP-2831

Remove the deprecated INode.getAbsoluteName()

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.17.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change
    • Release Note:
      Removes deprecated method INode#getAbsoluteName()

      Description

      The deprecated INode.getAbsoluteName() should be removed so that INode.parent could be eliminated later on.

      INode.getAbsoluteName() currently is only used in FSImage.writeINodeUnderConstruction(...) . It also introduces unnecessary recursion.

      1. HADOOP-2831-2.patch
        2 kB
        Lohit Vijayarenu
      2. HADOOP-2831-1.patch
        3 kB
        Lohit Vijayarenu

        Activity

        Tsz Wo Nicholas Sze created issue -
        Nigel Daley made changes -
        Field Original Value New Value
        Priority Major [ 3 ] Blocker [ 1 ]
        Hide
        Robert Chansler added a comment -

        If deprecated in 0.15, then remove for 0.17.
        Otherwise set the fix version for this issue to 0.18.

        Show
        Robert Chansler added a comment - If deprecated in 0.15, then remove for 0.17. Otherwise set the fix version for this issue to 0.18.
        Robert Chansler made changes -
        Assignee lohit vijayarenu [ lohit ]
        Hide
        Lohit Vijayarenu added a comment -

        Attaching patch which deprecates the API. There is one another place where this is use in log message. I changed it to use fileName already present instead of absolutePath()

        Show
        Lohit Vijayarenu added a comment - Attaching patch which deprecates the API. There is one another place where this is use in log message. I changed it to use fileName already present instead of absolutePath()
        Lohit Vijayarenu made changes -
        Attachment HADOOP-2831-1.patch [ 12378974 ]
        Lohit Vijayarenu made changes -
        Attachment HADOOP-2831-1-2.patch [ 12378976 ]
        Lohit Vijayarenu made changes -
        Attachment HADOOP-2831-1-2.patch [ 12378976 ]
        Hide
        Lohit Vijayarenu added a comment -

        was getting rid of wrong getAbsoluteName(). Reverting that. Thanks Nicolas.

        Show
        Lohit Vijayarenu added a comment - was getting rid of wrong getAbsoluteName(). Reverting that. Thanks Nicolas.
        Lohit Vijayarenu made changes -
        Attachment HADOOP-2831-2.patch [ 12378977 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 codes look good.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 codes look good.
        Lohit Vijayarenu made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12378977/HADOOP-2831-2.patch
        against trunk revision 619744.

        @author +1. The patch does not contain any @author tags.

        tests included -1. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        patch -1. The patch command could not apply the patch.

        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2105/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12378977/HADOOP-2831-2.patch against trunk revision 619744. @author +1. The patch does not contain any @author tags. tests included -1. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. patch -1. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2105/console This message is automatically generated.
        Lohit Vijayarenu made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Lohit Vijayarenu made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12378977/HADOOP-2831-2.patch
        against trunk revision 643282.

        @author +1. The patch does not contain any @author tags.

        tests included -1. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        javadoc +1. The javadoc tool did not generate any warning messages.

        javac +1. The applied patch does not generate any new javac compiler warnings.

        release audit +1. The applied patch does not generate any new release audit warnings.

        findbugs +1. The patch does not introduce any new Findbugs warnings.

        core tests +1. The patch passed core unit tests.

        contrib tests +1. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2107/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2107/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2107/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2107/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12378977/HADOOP-2831-2.patch against trunk revision 643282. @author +1. The patch does not contain any @author tags. tests included -1. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. javadoc +1. The javadoc tool did not generate any warning messages. javac +1. The applied patch does not generate any new javac compiler warnings. release audit +1. The applied patch does not generate any new release audit warnings. findbugs +1. The patch does not introduce any new Findbugs warnings. core tests +1. The patch passed core unit tests. contrib tests +1. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2107/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2107/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2107/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2107/console This message is automatically generated.
        Hide
        Lohit Vijayarenu added a comment -

        This patch removes deprecated API does so testcases were not included.

        Show
        Lohit Vijayarenu added a comment - This patch removes deprecated API does so testcases were not included.
        Hide
        Chris Douglas added a comment -

        Would it make sense to remove o.a.h.dfs.BlockCrcUpgrade.INodeMapEntry::getAbsoluteName() as well?

        Show
        Chris Douglas added a comment - Would it make sense to remove o.a.h.dfs.BlockCrcUpgrade.INodeMapEntry::getAbsoluteName() as well?
        Hide
        Chris Douglas added a comment -

        Spoke with Lohit offline, cleared up my confusion.

        I just committed this. Thanks, Lohit!

        Show
        Chris Douglas added a comment - Spoke with Lohit offline, cleared up my confusion. I just committed this. Thanks, Lohit!
        Chris Douglas made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Robert Chansler added a comment -

        Noted as incompatible in changes.txt

        Show
        Robert Chansler added a comment - Noted as incompatible in changes.txt
        Robert Chansler made changes -
        Hadoop Flags [Incompatible change]
        Lohit Vijayarenu made changes -
        Release Note Removes deprecated method INode#getAbsoluteName()
        Nigel Daley made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Owen O'Malley made changes -
        Component/s dfs [ 12310710 ]

          People

          • Assignee:
            Lohit Vijayarenu
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development