Hadoop Common
  1. Hadoop Common
  2. HADOOP-2818

Remove deprecated Counters.getDisplayName(), getCounterNames(), getCounter(String counterName)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.16.0
    • Fix Version/s: 0.17.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change
    • Release Note:
      Hide
      The deprecated methods public String org.apache.hadoop.mapred.Counters.getDisplayName(String counter) and
      public synchronized Collection<String> org.apache.hadoop.mapred.Counters.getCounterNames() are removed.
      The deprecated method public synchronized long org.apache.hadoop.mapred.Counters.getCounter(String counterName) is undeprecated.
      Show
      The deprecated methods public String org.apache.hadoop.mapred.Counters.getDisplayName(String counter) and public synchronized Collection<String> org.apache.hadoop.mapred.Counters.getCounterNames() are removed. The deprecated method public synchronized long org.apache.hadoop.mapred.Counters.getCounter(String counterName) is undeprecated.

      Description

      Counters.getDisplayName(), getCounterNames(), getCounter(String counterName) need to removed as they are deprecated in 0.16.

      1. patch-2818.txt
        4 kB
        Amareshwari Sriramadasu

        Issue Links

          Activity

          Hide
          Amareshwari Sriramadasu added a comment -

          I think we can undeprecate Counters.Group.getCounter(String counterName)), because, if we remove that method, even if we already know the counterName, there is no other way to get the counter value otherthan iterating again.
          For ex. You may want to know the counter values in 3 groups simultaneously with a given counterName, all three groups have to be iterated if we remove this method.

          Show
          Amareshwari Sriramadasu added a comment - I think we can undeprecate Counters.Group.getCounter(String counterName)), because, if we remove that method, even if we already know the counterName, there is no other way to get the counter value otherthan iterating again. For ex. You may want to know the counter values in 3 groups simultaneously with a given counterName, all three groups have to be iterated if we remove this method.
          Hide
          Amareshwari Sriramadasu added a comment -

          Here is patch removing Counters.Group.getDisplayName(String counter) and Counters.Group.getCounterNames().

          Show
          Amareshwari Sriramadasu added a comment - Here is patch removing Counters.Group.getDisplayName(String counter) and Counters.Group.getCounterNames().
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12378617/patch-2818.txt
          against trunk revision 619744.

          @author +1. The patch does not contain any @author tags.

          tests included -1. The patch doesn't appear to include any new or modified tests.
          Please justify why no tests are needed for this patch.

          javadoc +1. The javadoc tool did not generate any warning messages.

          javac +1. The applied patch does not generate any new javac compiler warnings.

          release audit +1. The applied patch does not generate any new release audit warnings.

          findbugs +1. The patch does not introduce any new Findbugs warnings.

          core tests +1. The patch passed core unit tests.

          contrib tests +1. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2060/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2060/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2060/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2060/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12378617/patch-2818.txt against trunk revision 619744. @author +1. The patch does not contain any @author tags. tests included -1. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. javadoc +1. The javadoc tool did not generate any warning messages. javac +1. The applied patch does not generate any new javac compiler warnings. release audit +1. The applied patch does not generate any new release audit warnings. findbugs +1. The patch does not introduce any new Findbugs warnings. core tests +1. The patch passed core unit tests. contrib tests +1. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2060/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2060/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2060/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2060/console This message is automatically generated.
          Hide
          Amareshwari Sriramadasu added a comment -

          This patch doesnt require a testcase as it removes deprecated methods.

          Show
          Amareshwari Sriramadasu added a comment - This patch doesnt require a testcase as it removes deprecated methods.
          Hide
          Tom White added a comment -

          I've just committed this. Thanks Amareshwari!

          Show
          Tom White added a comment - I've just committed this. Thanks Amareshwari!
          Hide
          Robert Chansler added a comment -

          Noted as incompatible in changes.txt

          Show
          Robert Chansler added a comment - Noted as incompatible in changes.txt

            People

            • Assignee:
              Amareshwari Sriramadasu
              Reporter:
              Amareshwari Sriramadasu
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development