[HADOOP-2811] method Counters.makeCompactString() does not insert separator char ',' between the counters of different groups.

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 0.16.0
• Fix Version/s: 0.16.1
• Assignee: Runping Qi
• Reporter: Runping Qi
• Created: 13/Feb/08 02:11
• Updated: 08/Jul/09 16:52
• Resolved: 16/Feb/08 01:07

Description

The corrent code is:

 public synchronized String makeCompactString() {
    StringBuffer buffer = new StringBuffer();
      for(Group group: this){
      boolean first = true;
      for(Counter counter: group) {
        if (first) {
          first = false;
        } else {
          buffer.append(',');
        }
        buffer.append(group.getDisplayName());
        buffer.append('.');
        buffer.append(counter.getDisplayName());
        buffer.append('=');
        buffer.append(counter.getCounter());
      }
    }
    return buffer.toString();
  }

The correct code should be like:

 public synchronized String makeCompactString() {
    StringBuffer buffer = new StringBuffer();
    boolean first = true;
    for(Group group: this){
      
      for(Counter counter: group) {
        if (first) {
          first = false;
        } else {
          buffer.append(',');
        }
        buffer.append(group.getDisplayName());
        buffer.append('.');
        buffer.append(counter.getDisplayName());
        buffer.append('=');
        buffer.append(counter.getCounter());
      }
    }
    return buffer.toString();
  }