[MAPREDUCE-344] Remove dead code block in JobInProgress.completedTask

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Assignee: Unassigned
• Reporter: Arun Murthy
• Created: 29/Jan/08 04:41
• Updated: 17/Jul/14 20:02
• Resolved: 17/Jul/14 20:02

Description

Since the taskCommitThread ensures that one and only one task of a given TIP is marked as SUCCEEDED, we don't need the code block in JobInProgress.completedTask which checks if the TIP is complete and then just marks the task as complete:

    // Sanity check: is the TIP already complete? 
    if (tip.isComplete()) {
      // Mark this task as KILLED
      tip.alreadyCompletedTask(taskid);

      // Let the JobTracker cleanup this taskid if the job isn't running
      if (this.status.getRunState() != JobStatus.RUNNING) {
        jobtracker.markCompletedTaskAttempt(status.getTaskTracker(), taskid);
      }
      return false;
    }