Hadoop Common
  1. Hadoop Common
  2. HADOOP-260

the start up scripts should take a command line parameter --config making it easy to run multiple hadoop installation on same machines

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.2.0
    • Fix Version/s: 0.5.0
    • Component/s: None
    • Labels:
      None

      Description

      --config paramter would allow getting rid of SSH_OPTS.

      1. hadoop-config.patch
        9 kB
        Milind Bhandarkar

        Issue Links

          Activity

          Hide
          Vetle Roeim added a comment -

          As far as I can tell, it's still necessary to define a separate PID directory for this to work; the PID variable in hadoop-deamon.sh does not take the configuration directory into account. While having a separate PID directory per configuration is not a problem per se, it seems unnecessary.

          Show
          Vetle Roeim added a comment - As far as I can tell, it's still necessary to define a separate PID directory for this to work; the PID variable in hadoop-deamon.sh does not take the configuration directory into account. While having a separate PID directory per configuration is not a problem per se, it seems unnecessary.
          Hide
          Doug Cutting added a comment -

          I just committed this. Thanks, Milind!

          Show
          Doug Cutting added a comment - I just committed this. Thanks, Milind!
          Hide
          Milind Bhandarkar added a comment -

          Added a [--config confdir] optional parameter to all hadoop shell scripts. The scripts now use the portable source command to eliminate duplicate code.

          Show
          Milind Bhandarkar added a comment - Added a [--config confdir] optional parameter to all hadoop shell scripts. The scripts now use the portable source command to eliminate duplicate code.
          Hide
          Milind Bhandarkar added a comment -

          I have started looking at this issue. The original patch contains duplicate shell-script in all scripts. We could have separated it out as a function and included that file. However, in the meanwhile, the scripts have become portable across bourne-compatible shells, rather than being specific to bash. How do you propose we eliminate repeatition ?

          Show
          Milind Bhandarkar added a comment - I have started looking at this issue. The original patch contains duplicate shell-script in all scripts. We could have separated it out as a function and included that file. However, in the meanwhile, the scripts have become portable across bourne-compatible shells, rather than being specific to bash. How do you propose we eliminate repeatition ?
          Hide
          Mahadev konar added a comment -

          you are right Doug. I will factor it out., so that it looks much cleaner. Thanks for the input.

          Show
          Mahadev konar added a comment - you are right Doug. I will factor it out., so that it looks much cleaner. Thanks for the input.
          Hide
          Doug Cutting added a comment -

          I like what this does, but not particularly the way it is done. Having the same 20 lines repeated in 10 files seems fragile to me. Can we somehow instead put this logic in a single file that's included in all of the scripts?

          Show
          Doug Cutting added a comment - I like what this does, but not particularly the way it is done. Having the same 20 lines repeated in 10 files seems fragile to me. Can we somehow instead put this logic in a single file that's included in all of the scripts?
          Hide
          Mahadev konar added a comment -

          This patch allows for a --config command line argument to all the scripts. It still works if HADOOP_CONF_DIR env variable is set and --config is not specified.

          Show
          Mahadev konar added a comment - This patch allows for a --config command line argument to all the scripts. It still works if HADOOP_CONF_DIR env variable is set and --config is not specified.

            People

            • Assignee:
              Milind Bhandarkar
              Reporter:
              Mahadev konar
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development