Hadoop Common
  1. Hadoop Common
  2. HADOOP-260

the start up scripts should take a command line parameter --config making it easy to run multiple hadoop installation on same machines

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.2.0
    • Fix Version/s: 0.5.0
    • Component/s: None
    • Labels:
      None

      Description

      --config paramter would allow getting rid of SSH_OPTS.

      1. hadoop-config.patch
        9 kB
        Milind Bhandarkar

        Issue Links

          Activity

          Mahadev konar created issue -
          Hide
          Mahadev konar added a comment -

          This patch allows for a --config command line argument to all the scripts. It still works if HADOOP_CONF_DIR env variable is set and --config is not specified.

          Show
          Mahadev konar added a comment - This patch allows for a --config command line argument to all the scripts. It still works if HADOOP_CONF_DIR env variable is set and --config is not specified.
          Mahadev konar made changes -
          Field Original Value New Value
          Attachment config.patch [ 12334793 ]
          Hide
          Doug Cutting added a comment -

          I like what this does, but not particularly the way it is done. Having the same 20 lines repeated in 10 files seems fragile to me. Can we somehow instead put this logic in a single file that's included in all of the scripts?

          Show
          Doug Cutting added a comment - I like what this does, but not particularly the way it is done. Having the same 20 lines repeated in 10 files seems fragile to me. Can we somehow instead put this logic in a single file that's included in all of the scripts?
          Hide
          Mahadev konar added a comment -

          you are right Doug. I will factor it out., so that it looks much cleaner. Thanks for the input.

          Show
          Mahadev konar added a comment - you are right Doug. I will factor it out., so that it looks much cleaner. Thanks for the input.
          Sameer Paranjpye made changes -
          Affects Version/s 0.2 [ 12310813 ]
          Fix Version/s 0.3 [ 12310930 ]
          Sameer Paranjpye made changes -
          Link This issue duplicates HADOOP-155 [ HADOOP-155 ]
          Doug Cutting made changes -
          Fix Version/s 0.4 [ 12311021 ]
          Fix Version/s 0.3.0 [ 12310930 ]
          Doug Cutting made changes -
          Workflow jira [ 12372588 ] no reopen closed [ 12372958 ]
          Doug Cutting made changes -
          Workflow no reopen closed [ 12372958 ] no-reopen-closed [ 12373290 ]
          Doug Cutting made changes -
          Fix Version/s 0.5.0 [ 12311939 ]
          Fix Version/s 0.4.0 [ 12311021 ]
          Hide
          Milind Bhandarkar added a comment -

          I have started looking at this issue. The original patch contains duplicate shell-script in all scripts. We could have separated it out as a function and included that file. However, in the meanwhile, the scripts have become portable across bourne-compatible shells, rather than being specific to bash. How do you propose we eliminate repeatition ?

          Show
          Milind Bhandarkar added a comment - I have started looking at this issue. The original patch contains duplicate shell-script in all scripts. We could have separated it out as a function and included that file. However, in the meanwhile, the scripts have become portable across bourne-compatible shells, rather than being specific to bash. How do you propose we eliminate repeatition ?
          Milind Bhandarkar made changes -
          Attachment config.patch [ 12334793 ]
          Hide
          Milind Bhandarkar added a comment -

          Added a [--config confdir] optional parameter to all hadoop shell scripts. The scripts now use the portable source command to eliminate duplicate code.

          Show
          Milind Bhandarkar added a comment - Added a [--config confdir] optional parameter to all hadoop shell scripts. The scripts now use the portable source command to eliminate duplicate code.
          Milind Bhandarkar made changes -
          Attachment hadoop-config.patch [ 12337328 ]
          Hide
          Doug Cutting added a comment -

          I just committed this. Thanks, Milind!

          Show
          Doug Cutting added a comment - I just committed this. Thanks, Milind!
          Doug Cutting made changes -
          Assignee Mahadev konar [ mahadev ] Milind Bhandarkar [ milindb ]
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          Doug Cutting made changes -
          Workflow no-reopen-closed [ 12373290 ] no-reopen-closed, patch-avail [ 12377570 ]
          Doug Cutting made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Vetle Roeim added a comment -

          As far as I can tell, it's still necessary to define a separate PID directory for this to work; the PID variable in hadoop-deamon.sh does not take the configuration directory into account. While having a separate PID directory per configuration is not a problem per se, it seems unnecessary.

          Show
          Vetle Roeim added a comment - As far as I can tell, it's still necessary to define a separate PID directory for this to work; the PID variable in hadoop-deamon.sh does not take the configuration directory into account. While having a separate PID directory per configuration is not a problem per se, it seems unnecessary.
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          54d 7h 33m 1 Doug Cutting 24/Jul/06 10:16
          Resolved Resolved Closed Closed
          11d 13h 6m 1 Doug Cutting 04/Aug/06 23:22

            People

            • Assignee:
              Milind Bhandarkar
              Reporter:
              Mahadev konar
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development