Hadoop Common
  1. Hadoop Common
  2. HADOOP-246

the record-io generated c++ has wrong comments

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Duplicate
    • Affects Version/s: 0.2.1
    • Fix Version/s: 0.3.0
    • Component/s: record
    • Labels:
      None

      Description

      The comments on the namespaces on the closing come out backward:

      } // end namespace org
      } // end namespace apache
      } // end namespace hadoop
      } // end namespace record
      } // end namespace test

        Issue Links

          Activity

          Doug Cutting made changes -
          Workflow no-reopen-closed [ 12373474 ] no-reopen-closed, patch-avail [ 12377790 ]
          Doug Cutting made changes -
          Workflow no reopen closed [ 12373138 ] no-reopen-closed [ 12373474 ]
          Doug Cutting made changes -
          Workflow jira [ 12372341 ] no reopen closed [ 12373138 ]
          Doug Cutting made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Sameer Paranjpye made changes -
          Resolution Duplicate [ 3 ]
          Status Open [ 1 ] Resolved [ 5 ]
          Hide
          Sameer Paranjpye added a comment -

          Fix is part of patch in HADOOP-245

          Show
          Sameer Paranjpye added a comment - Fix is part of patch in HADOOP-245
          Sameer Paranjpye made changes -
          Fix Version/s 0.3 [ 12310930 ]
          Sameer Paranjpye made changes -
          Field Original Value New Value
          Link This issue is part of HADOOP-245 [ HADOOP-245 ]
          Hide
          Milind Bhandarkar added a comment -

          I have attached a patch to hadoop-245 that includes a fix for this bug as well. Repeated opening and closing of namespaces does not cause any runtime inefficiency. (and probably very small compile-time inefficiency.) However it makes the code generator hairier than it needs to be. That is why I open and close namespaces for each record independently.

          Show
          Milind Bhandarkar added a comment - I have attached a patch to hadoop-245 that includes a fix for this bug as well. Repeated opening and closing of namespaces does not cause any runtime inefficiency. (and probably very small compile-time inefficiency.) However it makes the code generator hairier than it needs to be. That is why I open and close namespaces for each record independently.
          Hide
          Owen O'Malley added a comment -

          It would also be nice if the namespaces weren't closed off just to be opened again...

          } // end namespace org
          } // end namespace apache
          } // end namespace hadoop
          } // end namespace record
          } // end namespace test
          namespace org {
          namespace apache {
          namespace hadoop {
          namespace record {
          namespace test {

          Show
          Owen O'Malley added a comment - It would also be nice if the namespaces weren't closed off just to be opened again... } // end namespace org } // end namespace apache } // end namespace hadoop } // end namespace record } // end namespace test namespace org { namespace apache { namespace hadoop { namespace record { namespace test {
          Owen O'Malley created issue -

            People

            • Assignee:
              Milind Bhandarkar
              Reporter:
              Owen O'Malley
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development