Hadoop Common
  1. Hadoop Common
  2. HADOOP-2132

Killing successfully completed jobs moves them to failed

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.18.0
    • Component/s: None
    • Labels:
      None
    • Environment:

      Hadoop cluster, after running one job

    • Hadoop Flags:
      Reviewed
    • Release Note:
      Change "job -kill" to only allow a job that is in the RUNNING or PREP state to be killed.

      Description

      Once a job is in completed state, run hadoop job -kill <jobid>, it moves to failed queue.

      1. hadoop-2132-v2.patch
        7 kB
        Jothi Padmanabhan

        Activity

        Srikanth Kakani created issue -
        Owen O'Malley made changes -
        Field Original Value New Value
        Fix Version/s 0.16.0 [ 12312740 ]
        Fix Version/s 0.15.0 [ 12312565 ]
        Nigel Daley made changes -
        Fix Version/s 0.16.0 [ 12312740 ]
        Jothi Padmanabhan made changes -
        Assignee Jothi Padmanabhan [ jothipn ]
        Hide
        Jothi Padmanabhan added a comment -

        Patch for Issue HADOOP-2132

        Show
        Jothi Padmanabhan added a comment - Patch for Issue HADOOP-2132
        Jothi Padmanabhan made changes -
        Attachment hadoop-2132.patch [ 12382621 ]
        Hide
        Jothi Padmanabhan added a comment -

        The patch is available for review.

        Changes:
        1. Modified the Kill Method in JobInProgress class to check if the job is either in the "RUNNING" or "PREP" state before killing it and moving it to the failed state.
        2. Modified "isSuccessful", "toString", and "is Complete" methods in JobClient to forcefully update their job status (instead of using the cached status) to return the most up-to-date status.

        Show
        Jothi Padmanabhan added a comment - The patch is available for review. Changes: 1. Modified the Kill Method in JobInProgress class to check if the job is either in the "RUNNING" or "PREP" state before killing it and moving it to the failed state. 2. Modified "isSuccessful", "toString", and "is Complete" methods in JobClient to forcefully update their job status (instead of using the cached status) to return the most up-to-date status.
        Jothi Padmanabhan made changes -
        Fix Version/s 0.18.0 [ 12312972 ]
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Amareshwari Sriramadasu added a comment -

        The code change in JobInProgress and JobClient looks good.
        Some comments in the testcase:
        1. The commented code in testcase needs to be removed.
        2. Is there any reason that testJob.jar is used as jar file for job submission? If not, wordcount can be launched without testJob.jar also.

        Show
        Amareshwari Sriramadasu added a comment - The code change in JobInProgress and JobClient looks good. Some comments in the testcase: 1. The commented code in testcase needs to be removed. 2. Is there any reason that testJob.jar is used as jar file for job submission? If not, wordcount can be launched without testJob.jar also.
        Jothi Padmanabhan made changes -
        Attachment hadoop-2132-v2.patch [ 12382769 ]
        Hide
        Jothi Padmanabhan added a comment -

        The new patch (incorporating the review comments) is now available for review

        Show
        Jothi Padmanabhan added a comment - The new patch (incorporating the review comments) is now available for review
        Hide
        Amareshwari Sriramadasu added a comment -

        +1 patch looks good.

        Show
        Amareshwari Sriramadasu added a comment - +1 patch looks good.
        Jothi Padmanabhan made changes -
        Attachment hadoop-2132.patch [ 12382621 ]
        Jothi Padmanabhan made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Jothi Padmanabhan added a comment -

        Resubmitting patch so that Hudson can pick it up

        Show
        Jothi Padmanabhan added a comment - Resubmitting patch so that Hudson can pick it up
        Jothi Padmanabhan made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12382769/hadoop-2132-v2.patch
        against trunk revision 661918.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 5 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2536/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2536/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2536/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2536/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12382769/hadoop-2132-v2.patch against trunk revision 661918. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2536/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2536/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2536/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2536/console This message is automatically generated.
        Hide
        Jothi Padmanabhan added a comment -

        dfs.TestEditLog failed with a time out. This is unrelated to the patch.

        Here is the log from the Test Report:

        org.apache.hadoop.dfs.TestEditLog.testEditLog
        Failing for the past 1 build (Since Failed#2536 )
        Took 0 seconds.

        junit.framework.AssertionFailedError: Timeout occurred. Please note the time in the report does not reflect the time until the timeout.

        Show
        Jothi Padmanabhan added a comment - dfs.TestEditLog failed with a time out. This is unrelated to the patch. Here is the log from the Test Report: org.apache.hadoop.dfs.TestEditLog.testEditLog Failing for the past 1 build (Since Failed#2536 ) Took 0 seconds. junit.framework.AssertionFailedError: Timeout occurred. Please note the time in the report does not reflect the time until the timeout.
        Hide
        Devaraj Das added a comment -

        I just committed this. Thanks, Jothi!

        Show
        Devaraj Das added a comment - I just committed this. Thanks, Jothi!
        Devaraj Das made changes -
        Hadoop Flags [Reviewed]
        Release Note Only RUNNING/PREP jobs can be killed.
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Robert Chansler made changes -
        Release Note Only RUNNING/PREP jobs can be killed. Change "job -kill" to only allow a job that is in the RUNNING or PREP state to be killed.
        Nigel Daley made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Owen O'Malley made changes -
        Component/s mapred [ 12310690 ]

          People

          • Assignee:
            Jothi Padmanabhan
            Reporter:
            Srikanth Kakani
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development