Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-1997

TestCheckpoint fails on Windows

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.15.0
    • Fix Version/s: 0.14.2, 0.15.0
    • Component/s: None
    • Labels:
      None
    • Environment:

      Windows

      Description

      The bug is in the test. TestCheckpoint opens edits files in order to verify its length but does not close it, so the
      secondary name-node attempt to delete it (in order to move edits.new into it on Win) fails.
      But this revealed 3 more bugs.

      • FSEditLog.purgeEditLog() in case of delete / rename failure calls FSEditLog.processIOError(), which should have
        failed because all FSEditLog streams are closed by that time. It does not because the condition for throwing the
        exception is incorrect.
      • In fact purgeEditLog() should call directly FSImage.processIOError() because again all streams are closed.
      • FSImage.processIOError() should also throw an exception if number of directories is <=1 rather than when it == 1

        Attachments

        1. TestCheckpoint.patch
          2 kB
          Konstantin Shvachko

          Activity

            People

            • Assignee:
              shv Konstantin Shvachko
              Reporter:
              shv Konstantin Shvachko

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment