Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.14.0
    • Fix Version/s: 0.23.0
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Multiple create methods in public FileSystem class lack documentation for the following 2 parameters.

      • long blockSize,
      • Progressable progress
      1. hadoop-1886-2.patch
        18 kB
        Eli Collins
      2. hadoop-1886-2.patch
        18 kB
        Eli Collins
      3. hadoop-1886-1.diff
        13 kB
        Frank Conrad

        Activity

        Hide
        Frank Conrad added a comment -

        add java doc

        Show
        Frank Conrad added a comment - add java doc
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12481945/hadoop-1886-1.diff
        against trunk revision 1133125.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/601//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/601//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/601//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481945/hadoop-1886-1.diff against trunk revision 1133125. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 2 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/601//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/601//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/601//console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        Thanks for contributing Frank!

        Show
        Eli Collins added a comment - Thanks for contributing Frank!
        Hide
        Eli Collins added a comment -

        Patch attached is a minor update to Frank's, fixes the two javadoc warnings and a couple minor things.

        Show
        Eli Collins added a comment - Patch attached is a minor update to Frank's, fixes the two javadoc warnings and a couple minor things.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12482017/hadoop-1886-2.patch
        against trunk revision 1133125.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/604//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/604//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/604//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12482017/hadoop-1886-2.patch against trunk revision 1133125. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/604//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/604//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/604//console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        Right patch this time.

        Show
        Eli Collins added a comment - Right patch this time.
        Hide
        Eli Collins added a comment -

        +1 to Frank's patch (w minor mods).

        Show
        Eli Collins added a comment - +1 to Frank's patch (w minor mods).
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12482019/hadoop-1886-2.patch
        against trunk revision 1133125.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/606//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/606//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/606//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12482019/hadoop-1886-2.patch against trunk revision 1133125. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/606//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/606//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/606//console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        I've committed this. Thanks Frank!

        Show
        Eli Collins added a comment - I've committed this. Thanks Frank!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #646 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/646/)
        HADOOP-1886. Undocumented parameters in FilesSystem. Contributed by Frank Conrad

        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134218
        Files :

        • /hadoop/common/trunk/CHANGES.txt
        • /hadoop/common/trunk/src/java/org/apache/hadoop/fs/FileSystem.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #646 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/646/ ) HADOOP-1886 . Undocumented parameters in FilesSystem. Contributed by Frank Conrad eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134218 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/src/java/org/apache/hadoop/fs/FileSystem.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-maven #11 (See https://builds.apache.org/job/Hadoop-Common-trunk-maven/11/)
        HADOOP-1886. Undocumented parameters in FilesSystem. Contributed by Frank Conrad

        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134218
        Files :

        • /hadoop/common/trunk/CHANGES.txt
        • /hadoop/common/trunk/src/java/org/apache/hadoop/fs/FileSystem.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-maven #11 (See https://builds.apache.org/job/Hadoop-Common-trunk-maven/11/ ) HADOOP-1886 . Undocumented parameters in FilesSystem. Contributed by Frank Conrad eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134218 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/src/java/org/apache/hadoop/fs/FileSystem.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #715 (See https://builds.apache.org/job/Hadoop-Common-trunk/715/)
        HADOOP-1886. Undocumented parameters in FilesSystem. Contributed by Frank Conrad

        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134218
        Files :

        • /hadoop/common/trunk/CHANGES.txt
        • /hadoop/common/trunk/src/java/org/apache/hadoop/fs/FileSystem.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #715 (See https://builds.apache.org/job/Hadoop-Common-trunk/715/ ) HADOOP-1886 . Undocumented parameters in FilesSystem. Contributed by Frank Conrad eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134218 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/src/java/org/apache/hadoop/fs/FileSystem.java

          People

          • Assignee:
            Frank Conrad
            Reporter:
            Konstantin Shvachko
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development