[HADOOP-18714] Wrong StringUtils.join() called in AbstractContractRootDirectoryTest

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 3.4.0, 3.3.6
• Fix Version/s: 3.4.0, 3.3.6
• Component/s: test
• Labels: pull-request-available
• Target Version/s: 3.4.0, 3.3.6
• Assignee: Attila Doroszlai
• Reporter: Attila Doroszlai
• Created: 21/Apr/23 13:56
• Updated: 23/Jan/24 02:46
• Resolved: 24/Apr/23 13:50

Description

In the following call to StringUtils.join(), "\n" is treated as an element, not as a separator:

https://github.com/apache/hadoop/blob/964c1902c8054dfe13c787222a12fb0daf1aaab9/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractRootDirectoryTest.java#L199-L201

    assertEquals("listStatus on empty root-directory returned found: "
        + join("\n", rootListStatus),
        0, rootListStatus.length);

Expected output:

[ERROR] Tests run: 9, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.711 s <<< FAILURE! - in org.apache.hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory
[ERROR] testListEmptyRootDirectory(org.apache.hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory)  Time elapsed: 0.011 s  <<< FAILURE!
java.lang.AssertionError: listStatus on empty root-directory returned found: HdfsLocatedFileStatus{path=hdfs://localhost:37225/test; isDirectory=true; ...} expected:<0> but was:<1>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.apache.hadoop.fs.contract.AbstractContractRootDirectoryTest.testListEmptyRootDirectory(AbstractContractRootDirectoryTest.java:199)

Actual output:

[ERROR] Tests run: 9, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.708 s <<< FAILURE! - in org.apache.hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory
[ERROR] testListEmptyRootDirectory(org.apache.hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory)  Time elapsed: 0.011 s  <<< FAILURE!
java.lang.AssertionError: 
listStatus on empty root-directory returned found: 
[Lorg.apache.hadoop.fs.FileStatus;@73344c46 expected:<0> but was:<1>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.apache.hadoop.fs.contract.AbstractContractRootDirectoryTest.testListEmptyRootDirectory(AbstractContractRootDirectoryTest.java:199)

Issue Links

• links to: GitHub Pull Request #5578
• links to: GitHub Pull Request #5588