[HADOOP-18547] Check if config value is not empty string in AbfsConfiguration.getMandatoryPasswordString()

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 3.3.4
• Component/s: fs/azure
• Labels: pull-request-available
• Assignee: Pranav Saxena
• Reporter: Pranav Saxena
• Created: 01/Dec/22 06:22
• Updated: 13/Feb/23 07:24

Description

The method `getMandatoryPasswordString` is called in `AbfsConfiguration.getTokenProvider()' to check if following configs are non-null (diff keys applicable for different implementation of AccessTokenProvider):

1. fs.azure.account.oauth2.client.endpoint: in ClientCredsTokenProvider
2. fs.azure.account.oauth2.client.id: in ClientCredsTokenProvider, MsiTokenProvider, RefreshTokenBasedTokenProvider
3. fs.azure.account.oauth2.client.secret: in ClientCredsTokenProvider
4. fs.azure.account.oauth2.client.endpoint: in UserPasswordTokenProvider
5. fs.azure.account.oauth2.user.name: in UserPasswordTokenProvider
6. fs.azure.account.oauth2.user.password: in UserPasswordTokenProvider
7. fs.azure.account.oauth2.msi.tenant: in MsiTokenProvider
8. fs.azure.account.oauth2.refresh.token: in RefreshTokenBasedTokenProvider

Right now, this method checks if its non-null and not non-empty. This task needs to add check on non-empty config values.

Issue Links

• links to: GitHub Pull Request #5177