[HADOOP-18364] All method metrics related to the RPC protocol should be initialized

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: metrics
• Labels: pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: Shuyan Zhang
• Reporter: Shuyan Zhang
• Created: 25/Jul/22 10:19
• Updated: 28/Jan/24 00:20
• Resolved: 04/Aug/22 05:02

Description

When an RPC protocol is used, the metric of protocol-related methods should be initialized; otherwise, metric information will be incomplete. For example, when we call HAServiceProtocol#monitorHealth(), only the metric of monitorHealth() are initialized, and the metric of transitionToStandby() are still not reported. This incompleteness caused a little trouble for our monitoring system.
The root cause is that the parameter passed by RpcEngine to MutableRatesWithAggregation#init(java.lang.Class<?>) is always XXXProtocolPB, which is inherited from BlockingInterface and does not implement any methods. We should fix this bug.

Issue Links

• links to: GitHub Pull Request #4624