[HADOOP-18238] Fix reentrancy check in SFTPFileSystem.close()

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3.1
• Fix Version/s: 3.3.5
• Component/s: common
• Labels: pull-request-available
• Target Version/s: 3.3.1
• Assignee: Ashutosh Gupta
• Reporter: yi liu
• Created: 17/May/22 04:10
• Updated: 30/May/22 16:37
• Resolved: 30/May/22 16:35

Description

@Override
public void close() throws IOException {
  if (closed.getAndSet(true)) {
    return;
  }
  try {
    super.close();
  } finally {
    if (connectionPool != null) {
      connectionPool.shutdown();
    }
  }
}

if you execute this method, the fs can not execute the deleteOnExit method because the fs is closed.

如果手动调用，sftp fs执行close方法关闭连接池，让jvm能正常退出，deleteOnExsist 将因为fs已关闭无法执行成功。如果不关闭，则连接池不会释放，jvm不能退出。

https://issues.apache.org/jira/browse/HADOOP-17528，这是3.2.0 sftpfilesystem的问题

 

Translated:

If it is called manually, sftp fs executes the close method to close the connection pool, so that the jvm can exit normally, deleteOnExist will fail to execute successfully because fs is closed. If it is not closed, the connection pool will not be released and the jvm cannot exit.

 

Issue Links

• is caused by: HADOOP-17528 Not closing an SFTP File System instance prevents JVM from exiting.
• links to: GitHub Pull Request #4330